Re: [PATCH v2 3/4] dt-bindings: display: add Amlogic Meson DRM Bindings

Neil Armstrong
2016-11-30T16:22:15Z

On 11/30/2016 05:21 PM, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> Hi Laurent,
>> On 11/30/2016 04:58 PM, Laurent Pinchart wrote:
>>> Hi Neil,
>>>
>>> On Wednesday 30 Nov 2016 16:43:44 Neil Armstrong wrote:
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> .../bindings/display/meson/meson-drm.txt | 101 ++++++++++++++++++
>>>
>>> I forgot to mention that the file should not be named meson-drm.txt as DRM is
>>> a Linux-specific concept. You can name it meson.txt, but a better option would
>>> be amlogic,meson.txt. By the way does it really need a subdirectory ?
>>
>> I took example of the sun4i layout the naming, and no it does not need a subdirector..
>>
>> I will move it to amlogic,meson.txt, seems far better.
>>
>
> To me, amlogic,meson is redundant. Probably should be amlogic,vpu.txt?
>
> Kevin
>

Yes, seems more coherent.

Thanks,
Neil