From: Andreas Schwab <schwab@linux-m68k.org>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Eric Paris <eparis@redhat.com>, linux-kernel@vger.kernel.org
Subject: struct fanotify_event_metadata
Date: Sat, 14 Aug 2010 19:44:38 +0200 [thread overview]
Message-ID: <m21va1ozqx.fsf@igel.home> (raw)
The pid field of struct fanotify_event_metadata has 64 bits which looks
excessive. Wouldn't it make sense to make it 32 bits and swap it with
the mask field? That would avoid the unaligned mask field, and remove
the need for the packed attribute.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2010-08-14 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 17:44 Andreas Schwab [this message]
2010-08-19 15:44 ` struct fanotify_event_metadata Tvrtko Ursulin
2010-08-19 16:07 ` Andreas Gruenbacher
2010-08-19 16:35 ` Tvrtko Ursulin
2010-08-19 17:53 ` Eric Paris
2010-08-20 9:02 ` Tvrtko Ursulin
2010-08-20 9:16 ` Andreas Schwab
2010-08-20 9:23 ` Tvrtko Ursulin
2010-08-20 13:13 ` Eric Paris
2010-08-20 13:27 ` Andreas Schwab
2010-08-20 15:19 ` Eric Paris
2010-08-20 17:47 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21va1ozqx.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=agruen@suse.de \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).