From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F8502E764D for ; Sat, 21 Feb 2026 10:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771669879; cv=none; b=CIuiLp7BiHez2aZHgWc7n0TdAwNCoGRKuLRLYU0igi2FBHWIZS7TU5kj94VzFWpKkWKDfkgVaf3wRntWEwlmpb+QgVJGQwh3Ln7IU7uH6SAI3hAUqaY/GHc1w+g64iy0vYKMJ2KseSn8Zkg8hO2EvfGSM+JwtyHnd1EyrCml4Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771669879; c=relaxed/simple; bh=6zvToDREd1uqPm2JTRwIInPJzKLUWy++t7sTHWHSMyk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Gygck+s88/6bMn1zP2E/x4aX3ldR8PK3Du9i5j2OaDpqmpHvVYYDnWXkx3QHFw0QVAhYwZmrOQeTjf3Jom65iP+QONKhvqUL33ugx2m/JbsPE09zHAjp7uc2CZGj7fyt7T/g85l95+eJejtj3uciqa6UGlsus45zOgJG6akX2d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NWMR/K2a; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NWMR/K2a" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-483a233819aso25023795e9.3 for ; Sat, 21 Feb 2026 02:31:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771669876; x=1772274676; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=u+lIaNVUZXvl7y4PjfhU9T+cs11HYw7PgGKqidav9Bo=; b=NWMR/K2a2x0iftw8rKZG4KNi+rk/B4uyFyVw4Z4nV/zMeEbpcPRj1pKWaWg9itYRRo FCX89+UqobYI5cToIdy6Z8TFRf4f9SmiVm+rvvwm5vhVbbJDaDbDqhHfnytaR4ov48yy TYYjuh9FhkQwcwzBvc5YEBf9SFKqWFjsM0dSlnXmnBR7dEUr5HIZQzwJXj22UmkVh30i Ulb2utl3toOX0IwSlkFIDgg1SbrSRZUIJNZmJ5DcOVHevcwAOAMJSPuqf28wWTVfBA8e 9vgMNxP4RM3znVxMIEOMlhYLwd8j9tdFcOwbx6T5K1PefMRrswcLB3C/Lk7dM5t+AtXA oTiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771669876; x=1772274676; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u+lIaNVUZXvl7y4PjfhU9T+cs11HYw7PgGKqidav9Bo=; b=onQLY5wUWr0KFrXkwM9pw7/ydC3uMCHOFTjPqvlCmrGrkFSWEAxk2Fll17l15TpCBC dBRA0BRjSYUYGiR+JNCOUlDhJu7wXhwtKWbqFKAQC44e7p6/ywQWkLCpszscW2J9TwtW +6rm/7J1TeJ1Xtyzbh77dJbe5jqCNJuoJB9AdQwu39l5KuBKOIBUztDT5yDQDnItZjM/ Mqqj7Eyvi6OykQiI9Yk7/6pi+pk2pxkT7VYalLy87KA2oiJJW5XZgvMT9CLkLKcK9+Gf gI9ftonm1RIeP4Q6i8Y8xvAb3cmtvTxLpACvxib5iFBwok8AS9jJArvDu/pEEZMmgQlT tsZw== X-Forwarded-Encrypted: i=1; AJvYcCUJ537FWoDZPswmjy8ciiTqLMQGRWWQTi0P1IqyMROMrEXOyv9XlAhwkQEhPop9R0yRUlIGDFryDSoXaRU=@vger.kernel.org X-Gm-Message-State: AOJu0YwB/4lZwl34mPL3IpBk9xeHf22pAgITXRD/33kpvJjip3l2fPcQ yd/ehVEFo+D/ftezaW6x7xaN7Z/3UaS4ACHCr56rzWicC+I++ZiCKcxF X-Gm-Gg: AZuq6aLjylIPLYrD/fwYMp1lA+osjK4KSNTKbC4ploVLWLvL2nGNKWcicnPviggQqZ5 EEamHUr9obw4myRjicwnAosXph3u3xyw1bMI4zfgvpDP++y2eAvnbGowG+fyR3IVxGAsH6GrLIn WH7QoQImGH9zEDUKaqS/56UvOeb7RfgPMX64SS5vo+0GPxDN3/CKjskyjJ4JbA3X8Y+x10rNMJU DSAXL0I1KziFl4Gsh5wo8drFp8Vd2o2HOXOAxWlCq8BOvreX6dPAnwMZtRMK/nM43C/ZCLuM7JO rfMV7+HhR3xKSYKh+cDwiq7qH780Vex3ahoXxVjRgSrK6UmVwtctCuK40HUx8Sir8vaNlnPQwvT of7ep4gdxW8BcSuAoQlA5aPlYZm8erfaUvlch5ZFSR4GzImaUSHYq+ukrbXyjaCiV5swgHLr87b Cx1X1+56/I4DTfKJGVVhQw2ea2YMvl4vEsLK/YVltShC1xV9cwE0cBH0PthFiC+1ZdUA== X-Received: by 2002:a05:600c:6298:b0:477:5c58:3d42 with SMTP id 5b1f17b1804b1-483a95fb23amr40728085e9.10.1771669876321; Sat, 21 Feb 2026 02:31:16 -0800 (PST) Received: from Abds-MacBook-Air.local ([2a02:3037:22e:87e2:bdae:6d22:aff8:39f1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d4c96csm5243449f8f.30.2026.02.21.02.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 02:31:15 -0800 (PST) From: Abd-Alrhman Masalkhi To: Ding Yihan , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Cc: dwlsalmeida@gmail.com, mchehab@kernel.org, linmag7@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com Subject: Re: [PATCH] media: vidtv: fix uninitialized args.buf_sz passed by value In-Reply-To: References: Date: Sat, 21 Feb 2026 11:31:14 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Feb 20, 2026 at 21:39 +0800, Ding Yihan wrote: > Hi Thomas and Abd-Alrhman, > > While looking into this exact same syzbot report, I noticed that > `vidtv_ts_pcr_write_into()` in the same file also suffers from the > exact same pass-by-value anti-pattern (passing `struct pcr_write_args` by value). > > Since `pcr_write_args` also contains implicit padding, it remains a potential trigger > for identical KMSAN uninit-value warnings during fuzzing in the future. > > Also, regarding Thomas's concern about modifying shared data: passing the struct > as a `const pointer` (e.g., `const struct null_packet_write_args *`) > would perfectly guarantee that the state remains read-only. > > Thomas, would it be worth submitting a separate patch now to fix `vidtv_ts_pcr_write_into()` > to prevent future KMSAN errors? Or would you prefer this to be addressed together in Abd-Alrhman's v2? > > Best regards, > Yihan Ding > Hi Yihan Ding, Thanks again for pointing this out earlier. I've added a fix for vidtv_ts_pcr_write_into() in v2, and I'd like to include a Suggested-by: tag for you in the patch. I'm still new here, but my understanding is that Suggested-by is the appropriate tag in this case. -- Best Regards, Abd-Alrhman