From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751470AbdB1SOd (ORCPT ); Tue, 28 Feb 2017 13:14:33 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:35135 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbdB1SOa (ORCPT ); Tue, 28 Feb 2017 13:14:30 -0500 From: Kevin Hilman To: Jerome Brunet Cc: Michael Turquette , Stephen Boyd , Carlo Caione , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: meson: fix SET_PARM macro Organization: BayLibre References: <20170228093016.5624-1-jbrunet@baylibre.com> Date: Tue, 28 Feb 2017 10:04:05 -0800 In-Reply-To: <20170228093016.5624-1-jbrunet@baylibre.com> (Jerome Brunet's message of "Tue, 28 Feb 2017 10:30:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Brunet writes: > parameter val is not enclosed in parenthesis which is buggy when given an > expression instead of a simple value > > Signed-off-by: Jerome Brunet Reviewed-by: Kevin Hilman > --- > drivers/clk/meson/clkc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/clkc.h b/drivers/clk/meson/clkc.h > index 9bb70e7a7d6a..c6be77dd8694 100644 > --- a/drivers/clk/meson/clkc.h > +++ b/drivers/clk/meson/clkc.h > @@ -25,7 +25,7 @@ > #define PARM_GET(width, shift, reg) \ > (((reg) & SETPMASK(width, shift)) >> (shift)) > #define PARM_SET(width, shift, reg, val) \ > - (((reg) & CLRPMASK(width, shift)) | (val << (shift))) > + (((reg) & CLRPMASK(width, shift)) | ((val) << (shift))) > > #define MESON_PARM_APPLICABLE(p) (!!((p)->width))