From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964850AbdBQXDn (ORCPT ); Fri, 17 Feb 2017 18:03:43 -0500 Received: from mail-pg0-f53.google.com ([74.125.83.53]:36239 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964814AbdBQXDm (ORCPT ); Fri, 17 Feb 2017 18:03:42 -0500 From: Kevin Hilman To: =?utf-8?Q?Micha=C5=82?= Zegan Cc: Carlo Caione , Ulf Hansson , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Organization: BayLibre References: <20170216145222.1577-1-webczat@webczatnet.pl> <20170216145222.1577-3-webczat@webczatnet.pl> <171193cd-e82d-695a-22b3-c10d670baad7@webczatnet.pl> Date: Fri, 17 Feb 2017 15:03:34 -0800 In-Reply-To: <171193cd-e82d-695a-22b3-c10d670baad7@webczatnet.pl> (=?utf-8?Q?=22Micha=C5=82?= Zegan"'s message of "Fri, 17 Feb 2017 20:50:55 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1HN3ol2015148 Michał Zegan writes: > W dniu 17.02.2017 o 20:47, Kevin Hilman pisze: >> Michał Zegan writes: >> >>> The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove. >>> Fix that by removing the host before deallocating other resources. >>> >>> Signed-off-by: Michał Zegan >> Reviewed-by: Kevin Hilman > > I do not know how the mmc driver looks like after Heiner's cleanup. Does > this patch get obsoleted by the prior cleanup, or conflict with it in > some way? It's not obsoleted, as I don't think Heiner's series fixes this problem, but it may have minor conflicts. I suggest you rebase this patch on top of Heiner's v2 to double check, and resend if necessary, noting in the patch (after the '---') what it applies on top of so that the MMC maintainers don't have to figure it out. Thanks, Kevin >> >>> --- >>> drivers/mmc/host/meson-gx-mmc.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c >>> index d444b6bfa02b..bb83446118a3 100644 >>> --- a/drivers/mmc/host/meson-gx-mmc.c >>> +++ b/drivers/mmc/host/meson-gx-mmc.c >>> @@ -818,6 +818,8 @@ static int meson_mmc_remove(struct platform_device *pdev) >>> if (WARN_ON(!host)) >>> return 0; >>> >>> + mmc_remove_host(host->mmc); >>> + >>> if (host->bounce_buf) >>> dma_free_coherent(host->dev, host->bounce_buf_size, >>> host->bounce_buf, host->bounce_dma_addr);