From: Kevin Hilman <khilman@baylibre.com>
To: David Lechner <david@lechnology.com>
Cc: Mark Brown <broonie@kernel.org>,
nsekhar@ti.com, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND] spi: davinci: Allow device tree devices to use DMA
Date: Thu, 12 Jan 2017 13:34:10 -0800 [thread overview]
Message-ID: <m24m146jzh.fsf@baylibre.com> (raw)
In-Reply-To: <1483673177-31516-1-git-send-email-david@lechnology.com> (David Lechner's message of "Thu, 5 Jan 2017 21:26:17 -0600")
David Lechner <david@lechnology.com> writes:
> This allows SPI devices specified in a device tree to use DMA when the
> master controller.
Enabling DMA for spi-davinci isn't quite ready yet since this driver is
blindly using dma_map_single() on addresses passed in. MTD seems to use
vmalloc'd buffers, which cannot be passed direclty to dma_map_single().
I thinks this driver needs an update to use spi_map_buf() to be able to
handle vmalloc'd buffers before always enabling DMA.
Kevin
next prev parent reply other threads:[~2017-01-12 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 3:26 [RESEND] spi: davinci: Allow device tree devices to use DMA David Lechner
2017-01-09 19:48 ` Mark Brown
2017-01-09 20:40 ` David Lechner
2017-01-10 16:51 ` Mark Brown
2017-01-12 21:34 ` Kevin Hilman [this message]
2017-01-13 12:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24m146jzh.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).