From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198Ab1LUXzM (ORCPT ); Wed, 21 Dec 2011 18:55:12 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:47020 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309Ab1LUXzK (ORCPT ); Wed, 21 Dec 2011 18:55:10 -0500 X-Auth-Info: ZGwDiEnXfRttZ1+iln0duh7H5EBopbptv5e+8TTOrRk= From: Andreas Schwab To: Andrew Morton Cc: Michal Hocko , Arnd Bergmann , linux-kernel@vger.kernel.org, "Artem S. Tashkinov" , Dave Jones , Alexey Dobriyan , Thomas Gleixner , Martin Schwidefsky Subject: Re: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t References: <201112120922.13633.arnd@arndb.de> <20111212124333.GC14720@tiehlicka.suse.cz> <20111212131218.GD14720@tiehlicka.suse.cz> <20111221100334.GD27137@tiehlicka.suse.cz> <20111221115919.6beac46f.akpm@linux-foundation.org> X-Yow: You were s'posed to laugh! Date: Thu, 22 Dec 2011 00:55:07 +0100 In-Reply-To: <20111221115919.6beac46f.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 21 Dec 2011 11:59:19 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > Also, in include/asm-generic/cputime.h we have: > > #define usecs_to_cputime64(__msecs) nsecs_to_jiffies64((__msecs) * 1000) > > But it would be neater to have used nsecs_to_cputime64(), surely. The procfs interface wants to convert usecs to cputime64, but generic cputime does not have usecs_to_jiffies64. Once someone writes the latter it can be used here. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."