From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jiri Kosina <jkosina@suse.cz>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Linux\/m68k" <linux-m68k@vger.kernel.org>
Subject: Re: [regression v2.6.38] Re: [PATCH v2] brk: fix min_brk lower bound computation for COMPAT_BRK
Date: Tue, 29 Mar 2011 22:37:38 +0200 [thread overview]
Message-ID: <m262r1hdd9.fsf@igel.home> (raw)
In-Reply-To: <AANLkTi=pNxVY8NZjRhT_aJMQNiTpfkmECqc-ZnTD7ynW@mail.gmail.com> (Geert Uytterhoeven's message of "Tue, 29 Mar 2011 22:24:21 +0200")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Seems like the binary doesn't like brk() rounding up the requested
> value to the next page...
>From libc-5.4.46/libc/sysdeps/linux/m68k/__sbrk.c:
void *
__sbrk(ptrdiff_t increment)
{
if (__init_brk () == 0)
{
register void * tmp asm ("%d1") = ___brk_addr+increment;
__asm__ volatile ("movel %1,%/d0\n\t"
"trap #0\n\t"
"movel %/d0,%0"
:"=g" (___brk_addr)
:"i" (SYS_brk),"g" (tmp) : "%d0");
if (___brk_addr == tmp)
return tmp-increment;
errno = ENOMEM;
}
return ((void *) -1);
}
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-03-29 20:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 23:05 [PATCH] brk: fix min_brk lower bound computation for COMPAT_BRK Jiri Kosina
2011-01-03 11:39 ` Jiri Kosina
2011-01-03 13:24 ` [PATCH v2] " Jiri Kosina
2011-03-24 21:49 ` [regression v2.6.38] " Geert Uytterhoeven
2011-03-25 10:20 ` Jiri Kosina
2011-03-26 13:51 ` Geert Uytterhoeven
2011-03-28 14:20 ` Jiri Kosina
2011-03-29 20:24 ` Geert Uytterhoeven
2011-03-29 20:37 ` Andreas Schwab [this message]
2011-04-06 20:08 ` Jiri Kosina
2011-04-06 20:23 ` Geert Uytterhoeven
2011-04-06 20:38 ` [PATCH] brk: COMPAT_BRK: fix detection of randomized brk (was Re: [regression v2.6.38] Re: [PATCH v2] brk: fix min_brk lower bound computation forCOMPAT_BRK) Jiri Kosina
2011-04-06 20:40 ` Geert Uytterhoeven
2011-04-06 20:42 ` Jiri Kosina
2011-03-29 12:02 ` [regression v2.6.38] Re: [PATCH v2] brk: fix min_brk lower bound computation for COMPAT_BRK Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m262r1hdd9.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox