public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, Nishanth Menon <nm@ti.com>,
	Keerthy <j-keerthy@ti.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Tero Kristo <t-kristo@ti.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells
Date: Fri, 10 Mar 2017 13:18:47 -0800	[thread overview]
Message-ID: <m27f3wg79k.fsf@baylibre.com> (raw)
In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> (Dave Gerlach's message of "Tue, 7 Mar 2017 04:22:31 -0600")

Dave Gerlach <d-gerlach@ti.com> writes:

> There is no reason that a platform genpd driver registered using
> of_genpd_add_provider_simple needs to be constrained to having no cells
> in the "power-domains" phandle. Currently the genpd framework will fail
> if any arguments are passed with for a simple provider but the framework
> does not actually care, so remove the check for phandle argument count.
>
> This will allow greater flexibility for genpd providers to use their own
> arguments that are passed in the phandle and interpret them however they
> see fit.
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
> v3->v4:
>  Drop ti,sci-id device property and instead describe using phandle cell
>  for id.
>
>  drivers/base/power/domain.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index e697dec9d25b..8e0550c27394 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple(
>  					struct of_phandle_args *genpdspec,
>  					void *data)
>  {
> -	if (genpdspec->args_count != 0)
> -		return ERR_PTR(-EINVAL);
>  	return data;
>  }

  reply	other threads:[~2017-03-10 21:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 10:22 [PATCH v4 0/5] ARM: K2G: Add support for TI-SCI Generic PM Domains Dave Gerlach
2017-03-07 10:22 ` [PATCH v4 1/5] PM / Domains: Add generic data pointer to genpd data struct Dave Gerlach
2017-03-10 21:19   ` Kevin Hilman
2017-03-07 10:22 ` [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells Dave Gerlach
2017-03-10 21:18   ` Kevin Hilman [this message]
2017-03-13  8:20   ` Ulf Hansson
2017-03-07 10:22 ` [PATCH v4 3/5] dt-bindings: Add TI SCI PM Domains Dave Gerlach
2017-03-12 17:21   ` santosh.shilimkar
2017-03-13  8:21   ` Ulf Hansson
2017-03-15 17:53   ` Rob Herring
2017-03-15 20:14     ` Dave Gerlach
2017-03-16 18:27   ` [PATCH v5 " Dave Gerlach
2017-03-18 20:38     ` Rob Herring
2017-03-07 10:22 ` [PATCH v4 4/5] soc: ti: Add ti_sci_pm_domains driver Dave Gerlach
2017-03-10 21:22   ` Kevin Hilman
2017-03-12 17:20   ` santosh.shilimkar
2017-03-13  8:21   ` Ulf Hansson
2017-03-07 10:22 ` [PATCH v4 5/5] ARM: keystone: Drop PM domain support for k2g Dave Gerlach
2017-03-12 17:20   ` santosh.shilimkar
2017-03-12 17:02 ` [PATCH v4 0/5] ARM: K2G: Add support for TI-SCI Generic PM Domains Rafael J. Wysocki
2017-03-16 18:31   ` Dave Gerlach
2017-04-03 16:58     ` santosh.shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m27f3wg79k.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=t-kristo@ti.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox