From: Kevin Hilman <khilman@baylibre.com>
To: Eric Anholt <eric@anholt.net>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk,
Ulf Hansson <ulf.hansson@linaro.org>,
Alexander Aring <alex.aring@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: bcm2835: remove unused __packet
Date: Fri, 10 Jun 2016 15:11:15 -0700 [thread overview]
Message-ID: <m27fdwy9rw.fsf@baylibre.com> (raw)
In-Reply-To: <87shwo68su.fsf@eliezer.anholt.net> (Eric Anholt's message of "Tue, 07 Jun 2016 13:30:41 -0700")
Eric Anholt <eric@anholt.net> writes:
> Ben Dooks <ben.dooks@codethink.co.uk> writes:
>
>> The driver defines a variable called __packet but then never
>> uses it, and does not export it for others to use either. Fix
>> the warning about undeclared variable by removing it.
>>
>> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> PM folks: I'd be happy to see this go through your trees, but either way
> is fine with me.
Since this is in drivers/soc, just include it in your cleanup branch for
arm-soc.
Kevin
next prev parent reply other threads:[~2016-06-10 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:49 [PATCH] ARM: bcm2835: remove unused __packet Ben Dooks
2016-06-07 20:30 ` Eric Anholt
2016-06-10 22:11 ` Kevin Hilman [this message]
2016-06-13 15:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27fdwy9rw.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=alex.aring@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox