From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933061AbcFJWLX (ORCPT ); Fri, 10 Jun 2016 18:11:23 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35717 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932447AbcFJWLS (ORCPT ); Fri, 10 Jun 2016 18:11:18 -0400 From: Kevin Hilman To: Eric Anholt Cc: Ben Dooks , linux-kernel@lists.codethink.co.uk, Ulf Hansson , Alexander Aring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: bcm2835: remove unused __packet Organization: BayLibre References: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> <87shwo68su.fsf@eliezer.anholt.net> Date: Fri, 10 Jun 2016 15:11:15 -0700 In-Reply-To: <87shwo68su.fsf@eliezer.anholt.net> (Eric Anholt's message of "Tue, 07 Jun 2016 13:30:41 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Anholt writes: > Ben Dooks writes: > >> The driver defines a variable called __packet but then never >> uses it, and does not export it for others to use either. Fix >> the warning about undeclared variable by removing it. >> >> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static? > > Reviewed-by: Eric Anholt > > PM folks: I'd be happy to see this go through your trees, but either way > is fine with me. Since this is in drivers/soc, just include it in your cleanup branch for arm-soc. Kevin