From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A226DCA0FF3 for ; Tue, 5 Sep 2023 16:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346672AbjIEQYJ (ORCPT ); Tue, 5 Sep 2023 12:24:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353996AbjIEJGO (ORCPT ); Tue, 5 Sep 2023 05:06:14 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 632B5CE; Tue, 5 Sep 2023 02:06:10 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-500b6456c7eso3978561e87.2; Tue, 05 Sep 2023 02:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693904768; x=1694509568; darn=vger.kernel.org; h=mime-version:user-agent:references:message-id:date:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=letwRErFMBgbPngILbkdV7sGxY9b/Xz8daRTCtIa2w8=; b=DXeAb6P65VKaB0RaSL+6ecESxBs71K0CTjrivB7HS4l2lQCVt53ISaT+oEfnceDEiy Hfwpf7U/PYJnDs7K4m0hSO6ymeROOQ3FHvkbXQeCkJZFajSFw3PbLvv0Kv6OMShUJDYf LbO2BF4Ztd/ccHJIsqbgzOc5LJF+vU1tnDaQ1O5sZK+2QJZG0KM0q1PvBaW6ietgLSjB BMHX9pudexW0JFOs/TKIcygHYYCROKEYjIkTmx2f32pulq8hPCj4BtodoYohx3y8gIqg L3aaRViW9lkDA9UobYZZF5nqAewEAzcVcgLJkYiruoyoKmOgkTwwY5iTxrxJsoDvLxrO gU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693904768; x=1694509568; h=mime-version:user-agent:references:message-id:date:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=letwRErFMBgbPngILbkdV7sGxY9b/Xz8daRTCtIa2w8=; b=XHf3XXRV7DPD84iO+YUtplk4M04lRNRTBXlO6kVy1zAJ1vT5M0GZSiY4rS1Rrjx3qq rdF34iTy2zZsDZEdifh0hhWiwWnT1SnSWSzf6h6w5FVPo47/VtLFyAUu8K2ceoKpl2pG t2cJkLQ/VAWLzLaHNJtLCG+RmGA1DE9kbwaC33bnJum7fQtBsj+LFY2NukoKLWh1BaAj zsIWSf+5IcKNuV3afLtxRGvGHOjtWIIE1Vxb7AlsVlE8eoAVKd8vAGc6WhJrnXu9tvg4 oj4Bd22lGFMR6FFGPXpJa4JvfcuVqn3+VpjnZLF0npKB9tTTpwTjM0lXQZB/cBrkUBim sASQ== X-Gm-Message-State: AOJu0YzP+Efs0MGAx+PlNkyUvDQ7igEGMFlYva1ATAG3U3Qz9r0C3spk LQWdX45ctqJ+oKcwwmmFEToFvVsKhJw0Sw== X-Google-Smtp-Source: AGHT+IErdz2nPOeeXQxbGqcrhny5C2Hrn3K8C7hP0c/COE1md7cNuUKpAMBmFeiG8NrKl+5520A6Aw== X-Received: by 2002:a2e:9d8d:0:b0:2bb:b01a:9226 with SMTP id c13-20020a2e9d8d000000b002bbb01a9226mr8748809ljj.7.1693904767873; Tue, 05 Sep 2023 02:06:07 -0700 (PDT) Received: from imac ([2a02:8010:60a0:0:4a6:d58b:abde:2218]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c379200b003fee65091fdsm19595905wmr.40.2023.09.05.02.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 02:06:06 -0700 (PDT) From: Donald Hunter To: David Wang <00107082@163.com> Cc: fw@strlen.de, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER In-Reply-To: <20230904102128.11476-1-00107082@163.com> (David Wang's message of "Mon, 4 Sep 2023 18:21:28 +0800") Date: Tue, 05 Sep 2023 10:05:26 +0100 Message-ID: References: <20230904102128.11476-1-00107082@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Wang <00107082@163.com> writes: > This sample code implements a simple ipv4 > blacklist via the new bpf type BPF_PROG_TYPE_NETFILTER, > which was introduced in 6.4. > > The bpf program drops package if destination ip address > hits a match in the map of type BPF_MAP_TYPE_LPM_TRIE, > > The userspace code would load the bpf program, > attach it to netfilter's FORWARD/OUTPUT hook, > and then write ip patterns into the bpf map. > > Signed-off-by: David Wang <00107082@163.com> > --- > samples/bpf/Makefile | 3 + > samples/bpf/netfilter_ip4_blacklist.bpf.c | 62 +++++++++++++++ > samples/bpf/netfilter_ip4_blacklist.c | 96 +++++++++++++++++++++++ > 3 files changed, 161 insertions(+) > create mode 100644 samples/bpf/netfilter_ip4_blacklist.bpf.c > create mode 100644 samples/bpf/netfilter_ip4_blacklist.c According to https://docs.kernel.org/process/coding-style.html#naming you should avoid new use of blacklist. You should use somethink like denylist or blocklist instead.