Re: [PATCH] media: meson: add missing allocation failure check on new_buf

Sergey Senozhatsky
2019-12-05T08:06:16Z

On (19/12/04 14:11), Colin King wrote:
[..]
> diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> index 0a1a04fd5d13..8dd1396909d7 100644
> --- a/drivers/staging/media/meson/vdec/vdec.c
> +++ b/drivers/staging/media/meson/vdec/vdec.c
> @@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb)
> struct amvdec_buffer *new_buf;
>
> new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);
> + if (!new_buf)
> + return;
> new_buf->vb = vb;

So the buffer is not getting recycled? IOW is leaked?

-ss