From: Kevin Hilman <khilman@baylibre.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Finlye Xiao <finley.xiao@rock-chips.com>,
srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
robh+dt@kernel.org, frowand.list@gmail.com, sre@kernel.org,
dbaryshkov@gmail.com, dwmw2@infradead.org, mark.rutland@arm.com,
nm@ti.com, rjw@rjwysocki.net, viresh.kumar@linaro.org,
sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
wxt@rock-chips.com, jay.xu@rock-chips.com,
rocky.hao@rock-chips.com, tim.chen@rock-chips.com,
tony.xie@rock-chips.com, ulysses.huang@rock-chips.com,
lin.huang@rock-chips.com
Subject: Re: [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys
Date: Fri, 19 Aug 2016 11:19:13 -0500 [thread overview]
Message-ID: <m2a8g8n33y.fsf@baylibre.com> (raw)
In-Reply-To: <2844104.lMUOkH8YJy@phil> (Heiko Stuebner's message of "Fri, 19 Aug 2016 00:29:55 +0200")
Heiko Stuebner <heiko@sntech.de> writes:
> Am Donnerstag, 18. August 2016, 13:28:58 CEST schrieb Kevin Hilman:
>> Finlye Xiao <finley.xiao@rock-chips.com> writes:
>> > From: Finley Xiao <finley.xiao@rock-chips.com>
>> >
>> > We will register a cpufreq notifier for adjusting opp's voltage, and it
>> > need to fetch cpu's leakage from efuse in the notifier_call. so the efuse
>> > driver should probe before cpufreq driver.
>> >
>> > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
>>
>> Why can't this be handled with deferred probling? initcall ordering is
>> a can of worms.
>
> I think the issue is less between efuse and avs driver, but more between avs
> driver and cpufreq. The avs driver aims to modify the opp table and thus wants
> to do that / register the notifier before cpufreq starts.
>
> And as there is no direct connection between cpufreq and the avs driver,
> making cpufreq defer probing is probably not really easy.
Thanks for the explanation.
Sounds like something that belongs in the changelog.
Kevin
next prev parent reply other threads:[~2016-08-19 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 8:52 [PATCH v2 0/4] PM / AVS: add Rockchip cpu avs Finlye Xiao
2016-08-18 8:52 ` [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys Finlye Xiao
2016-08-18 18:28 ` Kevin Hilman
2016-08-18 22:29 ` Heiko Stuebner
2016-08-19 16:19 ` Kevin Hilman [this message]
2016-08-18 8:52 ` [PATCH v2 2/4] of: introduce of_property_read_s32_index Finlye Xiao
2016-08-18 8:52 ` [PATCH v2 3/4] dt-bindings: add binding document for Rockchip cpu avs Finlye Xiao
2016-08-18 8:52 ` [PATCH v2 4/4] PM / AVS: rockchip-cpu-avs: add driver handling " Finlye Xiao
2016-08-18 19:02 ` Kevin Hilman
2016-08-29 6:08 ` Viresh Kumar
2016-09-12 21:55 ` Stephen Boyd
2016-09-26 3:55 ` Viresh Kumar
2016-09-26 8:05 ` Heiko Stuebner
2016-09-27 8:40 ` Finley Xiao
2016-09-27 22:14 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a8g8n33y.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=finley.xiao@rock-chips.com \
--cc=frowand.list@gmail.com \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=lin.huang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=rocky.hao@rock-chips.com \
--cc=sboyd@codeaurora.org \
--cc=sre@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tim.chen@rock-chips.com \
--cc=tony.xie@rock-chips.com \
--cc=ulysses.huang@rock-chips.com \
--cc=viresh.kumar@linaro.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox