From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 571B83DC4A4 for ; Fri, 10 Jul 2026 09:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783676557; cv=none; b=J9GCM7oZcXaEfqXJOm4tIeBXj9BFWEmbMYyde/MMxLty3lUQH1JB5jMDjcIT/69fQ/fMV6EFX/sFmNKxRLOv73tL1elxiaztfOafxUf/QAvBx+vpEcrJmBouyIjG2rpS1H0RO+t4oJ4KEC1juuPN+taj3mprM6/5nEgJddg6Gcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783676557; c=relaxed/simple; bh=xFH1rD3UNKEwCfdYVeHdylrKlpH4ZHCenwweazMVWcs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gW+vzo4XCy/+tz3gthhmpM2jMDxMDgVHYOn2CKZ7QLGA05WKa1Epb5E6DeyfRG7o8wz2OtcSxuMbLLQZUEAE8P1oQvetM69W2H7/1FCSek/1RGf6zKb7sutChtyEh3oy9k5qYW7Y2v06wm375WPAKJwSu/s8fO/fpcl/IjSm3uU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IpeVesOg; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IpeVesOg" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493bb510ce4so4909775e9.1 for ; Fri, 10 Jul 2026 02:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783676554; x=1784281354; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PxqgrnbODxEIpAImap5RWx9OoAsN974AT1Di2zs2rHA=; b=IpeVesOgf5SGsJw6cwnFgMmUSwOeJZDskraZ/F5GcUl1EgYkFE5GeT56q6jA6YvDHZ 5j3jCb3b8WOyLZv5yYkhe+d8PD1u0DdvjQkbDtqzHGOSZh1ERHIHUyNFk6TRu+6ZJUoE VAnLl55wPJ1Gm5Kb806TIa/DITWKpnwyr9iOP6Tp179W99DMT59WK+NT/OdZ++Iq6BzX qIvMvUGxDhy0yIA7TFRDxsaS7AgMILqfpG4VnbjFnid1k8NRluK4SYpkNrfdhPmMBXH7 TPWZLQn8RqyhOWFffkChtFKh2sBo/qQEumkXwttPyW2GNgmLOAXAKTj1nRyf+mljbb78 id1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783676554; x=1784281354; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=PxqgrnbODxEIpAImap5RWx9OoAsN974AT1Di2zs2rHA=; b=Bt09pkSkIF4lvZoYFS0dotE5hVpSdOHfCIgMsfBvl0jtjkE3kh+Izerl9zj8jEyDB/ +eGxR49NMXfzC+AWq+40tZKlMYwdlqhSoBi2O5AXdbe8kKDQag2cHG5LnzI+iPrkf1xH 829VHfQj1m3TjH7BzPZoqxO87SbRIpsZ10cLbd6mJ66uU5Bykro4UAyGscuXkO3qT/qw oNDVOxPgAbF2DZZAEYkHQAJ2/lYHqRAlBZqehOysoGzNOzZ8dZ9zJh2gVqiLCTi92VsQ JHYX9tOJdH4sf2zP+UdTdIn6uyKZiiD8P5GEvsVq07jy4fnkNdxgL2okTm8pHGwASvqj fxVA== X-Forwarded-Encrypted: i=1; AHgh+Rp4wR11KJr9RiHfxorZLMr9XtW8m6KoFFZ3EueUA11qJPHZJyTcNeruTkSM7Zl59tsEqWROc0QH56DQ8QQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8tOIXGAzRNRqdi+gdU/YfQ7n7myUcg4nd+VUlqbply0LrnT9G n/P6tn2cYx1MtT7tA1yXQr81MTywy8nnnjEuBG2oEFVO6Bb60lnwUi+5 X-Gm-Gg: AfdE7cllWFS+YFLF/Ka4AKyjw8koBFTUQC5Zx9+GFXtadNMCSDKU5MOvlRvYB+dbZb0 rLZaTsjWzndB+AEJ+HG7AF5ml8pHU6fEPmYk/TLaJXLDQTC1YL6pQQBt8rkFbi28zYTROF+Hty3 5RgxwygJ6QY3U/HweDZsfBP2ZXRR3GQ30L7VFXy2aqHvFRR/aEoT+iF+en4PoXwBeKAf1VGuaGp xBzfSGY/68DNoiRaar8lAiN178uByxJB8QwVtLenHfybNmQs4JxDtlGeToOnYKW7n5DXVzsoC/j oy920n3Z1SqozBqISnsTZabTwr9zWSIwGI26aKTQOuy5fmhBLc+BETpMYpsI4cLs1fX4KxZn/8y aWjJVzmYArWtYDwbIfYZeV0782eWp0XY4yY8tmENF5tx8/I1mXHCO96sWWJOA/8JDU8wyp7mk9f ckXWCFhQdQ1ub796cG8Q2JFR+tgpn3Kq0FmXUy+aOgWZ85/+n67wBUdraO/DMU0i9uGA== X-Received: by 2002:a05:600c:c16d:b0:493:a5da:e5d2 with SMTP id 5b1f17b1804b1-493f4fd49e4mr14403075e9.26.1783676553540; Fri, 10 Jul 2026 02:42:33 -0700 (PDT) Received: from Abds-MacBook-Air.local ([2a02:3037:622:2a80:61e9:bcbe:f38b:f871]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f3b85sm205135245e9.2.2026.07.10.02.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 02:42:33 -0700 (PDT) From: Abd-Alrhman Masalkhi To: John Garry , song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, vverma@digitalocean.com, martin.petersen@oracle.com, abd.masalkhi@gatech.edu, linux-kernel@vger.kernel.org Cc: linux-raid@vger.kernel.org Subject: Re: [PATCH v3 2/7] md/raid1: advertise atomic write limits and handle runtime constraints In-Reply-To: <350a2662-7de0-45e6-a905-76dbd0a99e98@oracle.com> References: <20260708101341.473750-1-abd.masalkhi@gmail.com> <20260708101341.473750-3-abd.masalkhi@gmail.com> <350a2662-7de0-45e6-a905-76dbd0a99e98@oracle.com> Date: Fri, 10 Jul 2026 11:42:31 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Jul 09, 2026 at 13:11 +0100, John Garry wrote: > On 08/07/2026 11:13, Abd-Alrhman Masalkhi wrote: >> Atomic writes in RAID1 must fit within a single barrier unit. Set >> chunk_sectors to BARRIER_UNIT_SECTOR_SIZE so that bios which would cross >> a barrier-unit boundary are rejected by the block layer before reaching >> MD. > > More accurate would be to say that we restrict the atomic write limits > so that we never produce a write which straddles BARRIER_UNIT_SECTOR_SIZE. > Yes, that is more accurate. I'll update the commit message accordingly. Thanks for the suggestion. >> >> A bio that passes block-layer validation may still become unserviceable >> within RAID1 due to bad blocks or write-behind constraints. In the former >> case, complete the bio with EIO. In the latter case, disable >> write-behind rather than failing the bio with EIO. >> >> Fixes: f2a38abf5f1c ("md/raid1: Atomic write support") >> Fixes: a4c55c902670 ("md/raid1: simplify raid1_write_request() error handling") >> Signed-off-by: Abd-Alrhman Masalkhi > > Reviewed-by: John Garry > > -- Best Regards, Abd-Alrhman