public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fiona Behrens <me@kloenk.dev>
To: Lyude Paul <lyude@redhat.com>
Cc: rust-for-linux@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration
Date: Wed, 26 Feb 2025 13:59:59 +0100	[thread overview]
Message-ID: <m2bjuolv3k.fsf@kloenk.dev> (raw)
In-Reply-To: <20250225213112.872264-2-lyude@redhat.com> (Lyude Paul's message of "Tue, 25 Feb 2025 16:29:00 -0500")

Lyude Paul <lyude@redhat.com> writes:

> I think this change got missed during review, we don't need
>  #[repr(transparent)] since Registration just holds a single NonNull. This
> attribute had originally been added by me when I was still figuring out how
> the bindings should look like but got committed by mistake. So, just drop
> it.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Fiona Behrens <me@Kloenk.dev>

> ---
>  rust/kernel/faux.rs | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/rust/kernel/faux.rs b/rust/kernel/faux.rs
> index 5acc0c02d451f..41751403cd868 100644
> --- a/rust/kernel/faux.rs
> +++ b/rust/kernel/faux.rs
> @@ -19,7 +19,6 @@
>  /// `self.0` always holds a valid pointer to an initialized and registered [`struct faux_device`].
>  ///
>  /// [`struct faux_device`]: srctree/include/linux/device/faux.h
> -#[repr(transparent)]
>  pub struct Registration(NonNull<bindings::faux_device>);
>  
>  impl Registration {

  parent reply	other threads:[~2025-02-26 13:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250225213112.872264-1-lyude@redhat.com>
2025-02-25 21:29 ` [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration Lyude Paul
2025-02-25 22:07   ` Danilo Krummrich
2025-02-26  8:39   ` Alice Ryhl
2025-02-26 12:59   ` Fiona Behrens [this message]
2025-02-25 21:29 ` [PATCH 2/2] rust/faux: Add missing parent argument to Registration::new() Lyude Paul
2025-02-25 22:07   ` Danilo Krummrich
2025-02-26  8:38   ` Alice Ryhl
2025-02-26  9:05     ` kernel
2025-02-26  9:03       ` kernel
2025-02-26  9:23       ` Alice Ryhl
2025-02-26  9:42         ` Danilo Krummrich
2025-02-26  9:51           ` Alice Ryhl
2025-02-26  9:58           ` Greg KH
2025-02-26 10:39             ` Danilo Krummrich
2025-02-26 11:01               ` Greg KH
2025-02-26 10:01   ` Greg Kroah-Hartman
2025-02-26 16:51     ` Lyude Paul
2025-02-26 19:31       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bjuolv3k.fsf@kloenk.dev \
    --to=me@kloenk.dev \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=mairacanal@riseup.net \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox