From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758185Ab2CIEbg (ORCPT ); Thu, 8 Mar 2012 23:31:36 -0500 Received: from void.printf.net ([89.145.121.20]:55650 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757437Ab2CIEbe (ORCPT ); Thu, 8 Mar 2012 23:31:34 -0500 From: Chris Ball To: Viresh Kumar Cc: , , , , , , , , , , , , , , Subject: Re: [PATCH] mmc/spear: add pm callbacks to support hibernation References: <452d8982fec5f41a3761a9e7b9bbe35e2f92c2a3.1330063674.git.viresh.kumar@st.com> Date: Thu, 08 Mar 2012 23:31:28 -0500 In-Reply-To: <452d8982fec5f41a3761a9e7b9bbe35e2f92c2a3.1330063674.git.viresh.kumar@st.com> (Viresh Kumar's message of "Fri, 24 Feb 2012 11:55:35 +0530") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, On Fri, Feb 24 2012, Viresh Kumar wrote: > From: Shiraz Hashim > > Signed-off-by: Shiraz Hashim > --- > drivers/mmc/host/sdhci-spear.c | 9 ++------- > 1 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index b7f8b33..6dfa82e 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -300,20 +300,15 @@ static int sdhci_resume(struct device *dev) > > return sdhci_resume_host(host); > } > - > -const struct dev_pm_ops sdhci_pm_ops = { > - .suspend = sdhci_suspend, > - .resume = sdhci_resume, > -}; > #endif > > +static SIMPLE_DEV_PM_OPS(sdhci_pm_ops, sdhci_suspend, sdhci_resume); > + > static struct platform_driver sdhci_driver = { > .driver = { > .name = "sdhci", > .owner = THIS_MODULE, > -#ifdef CONFIG_PM > .pm = &sdhci_pm_ops, > -#endif > }, > .probe = sdhci_probe, > .remove = __devexit_p(sdhci_remove), Thanks, pushed to mmc-next for 3.4. - Chris. -- Chris Ball One Laptop Per Child