From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261264AbVE3GcU (ORCPT ); Mon, 30 May 2005 02:32:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261523AbVE3GcU (ORCPT ); Mon, 30 May 2005 02:32:20 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:23037 "EHLO mail.asahi-net.or.jp") by vger.kernel.org with ESMTP id S261264AbVE3GcO (ORCPT ); Mon, 30 May 2005 02:32:14 -0400 Date: Mon, 30 May 2005 15:32:02 +0900 Message-ID: From: Yoshinori Sato To: Andrew Morton , domen@coderock.org Cc: linux-kernel@vger.kernel.org Subject: Re: [patch 1/1] ptrace_h8300: condition bugfix In-Reply-To: <20050528231627.776377000@nd47.coderock.org> References: <20050528231627.776377000@nd47.coderock.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) LIMIT/1.14.9 (Domyoji) APEL/10.6 Emacs/21.4 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 29 May 2005 01:16:28 +0200, domen@coderock.org wrote: > > From: Domen Puncer > > > Assignment doesn't make much sense here as condition would always be > true. > Thanks. I applied it. Signed-off-by: Domen Puncer Signed-off-by: Yoshinori Sato --- ptrace_h8300h.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c =================================================================== --- quilt.orig/arch/h8300/platform/h8300h/ptrace_h8300h.c +++ quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c @@ -245,12 +245,12 @@ static unsigned short *getnextpc(struct addr = h8300_get_reg(child, regno-1+PT_ER1); return (unsigned short *)addr; case relb: - if ((inst = 0x55) || isbranch(child,inst & 0x0f)) + if (inst == 0x55 || isbranch(child,inst & 0x0f)) pc = (unsigned short *)((unsigned long)pc + ((signed char)(*fetch_p))); return pc+1; /* skip myself */ case relw: - if ((inst = 0x5c) || isbranch(child,(*fetch_p & 0xf0) >> 4)) + if (inst == 0x5c || isbranch(child,(*fetch_p & 0xf0) >> 4)) pc = (unsigned short *)((unsigned long)pc + ((signed short)(*(pc+1)))); return pc+2; /* skip myself */ -- -- Yoshinori Sato