* Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu
2009-04-23 19:32 [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu Oleg Nesterov
@ 2009-04-24 1:17 ` Greg Ungerer
2009-04-24 7:03 ` Geert Uytterhoeven
2009-04-24 10:06 ` Andreas Schwab
2 siblings, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2009-04-24 1:17 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Roland McGrath, Chris Zankel, David Howells,
Geert Uytterhoeven, Greg Ungerer, Haavard Skinnemoen,
Helge Deller, Hirokazu Takata, Jeff Dike, Kyle McMartin,
Martin Schwidefsky, Mike Frysinger, Paul Mundt, Roman Zippel,
Yoshinori Sato, linux-kernel
Oleg Nesterov wrote:
> m68k sets PT_DTRACE in trap_c() but never uses it.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
> arch/m68k/kernel/traps.c | 1 -
> arch/m68knommu/kernel/asm-offsets.c | 1 -
> arch/m68knommu/kernel/traps.c | 1 -
> 3 files changed, 3 deletions(-)
>
> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET 2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68k/kernel/traps.c 2009-04-22 21:52:23.000000000 +0200
> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
> if (fp->ptregs.sr & PS_S) {
> if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
> /* traced a trapping instruction */
> - current->ptrace |= PT_DTRACE;
> } else
> bad_super_trap(fp);
> return;
> --- PTRACE/arch/m68knommu/kernel/asm-offsets.c~DT_3_SET 2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68knommu/kernel/asm-offsets.c 2009-04-22 21:53:46.000000000 +0200
> @@ -79,7 +79,6 @@ int main(void)
> DEFINE(TRAP_TRACE, TRAP_TRACE);
>
> DEFINE(PT_PTRACED, PT_PTRACED);
> - DEFINE(PT_DTRACE, PT_DTRACE);
>
> DEFINE(THREAD_SIZE, THREAD_SIZE);
>
> --- PTRACE/arch/m68knommu/kernel/traps.c~DT_3_SET 2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68knommu/kernel/traps.c 2009-04-22 21:54:29.000000000 +0200
> @@ -200,7 +200,6 @@ asmlinkage void trap_c(struct frame *fp)
> if (fp->ptregs.sr & PS_S) {
> if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
> /* traced a trapping instruction */
> - current->ptrace |= PT_DTRACE;
> } else
> bad_super_trap(fp);
> return;
>
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu
2009-04-23 19:32 [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu Oleg Nesterov
2009-04-24 1:17 ` Greg Ungerer
@ 2009-04-24 7:03 ` Geert Uytterhoeven
2009-04-24 10:06 ` Andreas Schwab
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2009-04-24 7:03 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Roland McGrath, Chris Zankel, David Howells,
Greg Ungerer, Haavard Skinnemoen, Helge Deller, Hirokazu Takata,
Jeff Dike, Kyle McMartin, Martin Schwidefsky, Mike Frysinger,
Paul Mundt, Roman Zippel, Yoshinori Sato, linux-kernel
On Thu, Apr 23, 2009 at 21:32, Oleg Nesterov <oleg@redhat.com> wrote:
> m68k sets PT_DTRACE in trap_c() but never uses it.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu
2009-04-23 19:32 [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu Oleg Nesterov
2009-04-24 1:17 ` Greg Ungerer
2009-04-24 7:03 ` Geert Uytterhoeven
@ 2009-04-24 10:06 ` Andreas Schwab
2009-04-24 10:57 ` Geert Uytterhoeven
2 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2009-04-24 10:06 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Roland McGrath, Chris Zankel, David Howells,
Geert Uytterhoeven, Greg Ungerer, Haavard Skinnemoen,
Helge Deller, Hirokazu Takata, Jeff Dike, Kyle McMartin,
Martin Schwidefsky, Mike Frysinger, Paul Mundt, Roman Zippel,
Yoshinori Sato, linux-kernel
Oleg Nesterov <oleg@redhat.com> writes:
> m68k sets PT_DTRACE in trap_c() but never uses it.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> arch/m68k/kernel/traps.c | 1 -
> arch/m68knommu/kernel/asm-offsets.c | 1 -
> arch/m68knommu/kernel/traps.c | 1 -
> 3 files changed, 3 deletions(-)
>
> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET 2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68k/kernel/traps.c 2009-04-22 21:52:23.000000000 +0200
> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
> if (fp->ptregs.sr & PS_S) {
> if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
> /* traced a trapping instruction */
> - current->ptrace |= PT_DTRACE;
This is supposed to be setting the TIF_DELAYED_TRACE thread flag.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu
2009-04-24 10:06 ` Andreas Schwab
@ 2009-04-24 10:57 ` Geert Uytterhoeven
2009-04-24 12:04 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2009-04-24 10:57 UTC (permalink / raw)
To: Andreas Schwab, Roman Zippel
Cc: Oleg Nesterov, Andrew Morton, Roland McGrath, Chris Zankel,
David Howells, Greg Ungerer, Haavard Skinnemoen, Helge Deller,
Hirokazu Takata, Jeff Dike, Kyle McMartin, Martin Schwidefsky,
Mike Frysinger, Paul Mundt, Yoshinori Sato, linux-kernel
On Fri, Apr 24, 2009 at 12:06, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Oleg Nesterov <oleg@redhat.com> writes:
>
>> m68k sets PT_DTRACE in trap_c() but never uses it.
>>
>> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>>
>> arch/m68k/kernel/traps.c | 1 -
>> arch/m68knommu/kernel/asm-offsets.c | 1 -
>> arch/m68knommu/kernel/traps.c | 1 -
>> 3 files changed, 3 deletions(-)
>>
>> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET 2009-04-06 00:03:35.000000000 +0200
>> +++ PTRACE/arch/m68k/kernel/traps.c 2009-04-22 21:52:23.000000000 +0200
>> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
>> if (fp->ptregs.sr & PS_S) {
>> if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
>> /* traced a trapping instruction */
>> - current->ptrace |= PT_DTRACE;
>
> This is supposed to be setting the TIF_DELAYED_TRACE thread flag.
This code already looks different in the m68k tree, due to your fix to
`Allow all kernel traps to be handled via exception fixups' for
ARAnyM, and some related cleanups by you and Roman.
But more interestingly, Roman's last cleanup said there's no need to
set TIF_DELAYED_TRACE?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu
2009-04-24 10:57 ` Geert Uytterhoeven
@ 2009-04-24 12:04 ` Andreas Schwab
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2009-04-24 12:04 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Roman Zippel, Oleg Nesterov, Andrew Morton, Roland McGrath,
Chris Zankel, David Howells, Greg Ungerer, Haavard Skinnemoen,
Helge Deller, Hirokazu Takata, Jeff Dike, Kyle McMartin,
Martin Schwidefsky, Mike Frysinger, Paul Mundt, Yoshinori Sato,
linux-kernel
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> But more interestingly, Roman's last cleanup said there's no need to
> set TIF_DELAYED_TRACE?
Ok, I remember now.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread