From: Peter Osterlund <petero2@telia.com>
To: Willy TARREAU <willy@w.ods.org>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel@vger.kernel.org,
netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH-2.4.26] ip6tables cleanup
Date: 28 Mar 2004 21:27:09 +0200 [thread overview]
Message-ID: <m2d66wsrg2.fsf@p4.localdomain> (raw)
In-Reply-To: <20040328115439.GA24421@pcw.home.local>
Willy TARREAU <willy@w.ods.org> writes:
> 2.4.26-rc1 returned this warning compiling ip6_tables :
>
> ip6_tables.c: In function `tcp_match':
> ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
>
> I had to add a cast because ipv6_skip_exthdr() expects a 'struct sk_buff*' while
> its caller uses a 'const struct sk_buff*'. Here is a cleanup patch.
I think it would be better to change the ipv6_skip_exthdr() function
to take a const struct sk_buff* instead. Unnecessary casts are evil.
--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
next prev parent reply other threads:[~2004-03-28 19:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-28 4:26 Linux 2.4.26-rc1 Marcelo Tosatti
2004-03-28 11:47 ` Willy TARREAU
2004-03-28 11:54 ` [PATCH-2.4.26] ip6tables cleanup Willy TARREAU
2004-03-28 19:27 ` Peter Osterlund [this message]
2004-03-28 20:09 ` Willy TARREAU
2004-03-28 20:33 ` David S. Miller
2004-03-28 22:38 ` Willy TARREAU
2004-03-28 23:00 ` David S. Miller
2004-03-28 20:16 ` David S. Miller
2004-03-28 11:57 ` [PATCH-2.4.26] cmpci cleanup Willy TARREAU
2004-03-29 12:19 ` Marcelo Tosatti
2004-03-28 12:12 ` [PATCH-2.4.26] smbfs cleanup Willy TARREAU
2004-03-28 12:15 ` [PATCH-2.4.26] sddr09 cleanup Willy TARREAU
2004-03-28 12:18 ` Willy TARREAU
2004-03-28 12:21 ` [PATCH-2.4.26] drm/radeon_mem cleanup Willy TARREAU
2004-03-28 12:24 ` [PATCH-2.4.26] cardbus cleanup Willy TARREAU
2004-03-28 12:40 ` Linux 2.4.26-rc1 => Alpha warnings Willy TARREAU
2004-03-28 16:34 ` Ivan Kokshaysky
2004-03-28 12:58 ` [PATCH-2.4.26] ATM cleanup Willy TARREAU
2004-03-28 13:03 ` Chris Wedgwood
2004-03-28 13:08 ` Willy TARREAU
2004-03-30 17:44 ` chas williams (contractor)
2004-03-31 3:18 ` David S. Miller
2004-03-28 13:38 ` [PATCH-2.4.26] AGPGART cleanup Willy TARREAU
2004-03-28 15:24 ` Linux 2.4.26-rc1 Arkadiusz Miskiewicz
2004-03-28 19:11 ` Peter Osterlund
2004-03-28 20:41 ` Frédéric L. W. Meunier
2004-04-01 0:47 ` Linux 2.4.26-rc1 - SCTP 'make xconfig' issue Sridhar Samudrala
2004-04-01 5:24 ` Peter Osterlund
2004-04-01 7:05 ` David S. Miller
2004-04-01 7:29 ` Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d66wsrg2.fsf@p4.localdomain \
--to=petero2@telia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox