From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759801Ab2HJXIq (ORCPT ); Fri, 10 Aug 2012 19:08:46 -0400 Received: from mga01.intel.com ([192.55.52.88]:13690 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756193Ab2HJXIR (ORCPT ); Fri, 10 Aug 2012 19:08:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,748,1336374000"; d="scan'208";a="197229877" From: Andi Kleen To: Naoya Horiguchi Cc: Andi Kleen , Wu Fengguang , Andrew Morton , Tony Luck , Rik van Riel , "Jun'ichi Nomura" , Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean References: <1344634913-13681-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1344634913-13681-2-git-send-email-n-horiguchi@ah.jp.nec.com> Date: Fri, 10 Aug 2012 16:08:10 -0700 In-Reply-To: <1344634913-13681-2-git-send-email-n-horiguchi@ah.jp.nec.com> (Naoya Horiguchi's message of "Fri, 10 Aug 2012 17:41:51 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Naoya Horiguchi writes: > action_result() fails to print out "dirty" even if an error occurred on a > dirty pagecache, because when we check PageDirty in action_result() it was > cleared after page isolation even if it's dirty before error handling. This > can break some applications that monitor this message, so should be fixed. > > There are several callers of action_result() except page_action(), but > either of them are not for LRU pages but for free pages or kernel pages, > so we don't have to consider dirty or not for them. Looks good Reviewed-by: Andi Kleen -Andi -- ak@linux.intel.com -- Speaking for myself only