public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h
@ 2011-08-15  2:28 Shawn Guo
  2011-08-15  3:54 ` Chris Ball
  0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2011-08-15  2:28 UTC (permalink / raw)
  To: linux-mmc; +Cc: linux-kernel, Chris Ball, Stephen Rothwell, patches, Shawn Guo

There are following warning and error when compiling the driver.
The patch adds the missing inclusion of linux/module.h to fix them.

drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’
drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: parameter names (without types) in function declaration
drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’
drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: parameter names (without types) in function declaration
drivers/mmc/host/sdhci-esdhc-imx.c:563:12: error: ‘THIS_MODULE’ undeclared here (not in a function)
drivers/mmc/host/sdhci-esdhc-imx.c:587:20: error: expected declaration specifiers or ‘...’ before string constant
drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DESCRIPTION’
drivers/mmc/host/sdhci-esdhc-imx.c:587:20: warning: function declaration isn’t a prototype
drivers/mmc/host/sdhci-esdhc-imx.c:588:15: error: expected declaration specifiers or ‘...’ before string constant
drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’
drivers/mmc/host/sdhci-esdhc-imx.c:588:15: warning: function declaration isn’t a prototype
drivers/mmc/host/sdhci-esdhc-imx.c:589:16: error: expected declaration specifiers or ‘...’ before string constant
drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: data definition has no type or storage class
drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_LICENSE’
drivers/mmc/host/sdhci-esdhc-imx.c:589:16: warning: function declaration isn’t a prototype

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Chris Ball <cjb@laptop.org>
---
Hi Stephen,

I spot this on linux-next-20110812.

Regards,
Shawn

 drivers/mmc/host/sdhci-esdhc-imx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 2a1ba84..4557aa1 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -16,6 +16,7 @@
 #include <linux/err.h>
 #include <linux/clk.h>
 #include <linux/gpio.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/mmc/host.h>
 #include <linux/mmc/mmc.h>
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-08-15  6:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-15  2:28 [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h Shawn Guo
2011-08-15  3:54 ` Chris Ball
2011-08-15  5:35   ` Shawn Guo
2011-08-15  5:46     ` Stephen Rothwell
2011-08-15  5:57       ` Chris Ball
2011-08-15  6:05       ` Shawn Guo
2011-08-15  6:44         ` Stephen Rothwell
2011-08-15  5:50     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox