Current perf tool does not compile anymore on RHEL6

Current perf tool does not compile anymore on RHEL6

[Andi Kleen]

Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA

Problem started with

commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4
Author: Jiri Olsa <jolsa@redhat.com>
Date:   Fri Jun 15 14:31:40 2012 +0800

    perf/tool: Add support to reuse event grammar to parse out terms


Unfortunately needs several other patches reverted too to revert.


    CC /home/ak/lsrc/obj-perf/util/symbol.o
util/parse-events.c: In function ‘parse_events__scanner’:
util/parse-events.c:695: warning: implicit declaration of function
‘parse_events_lex_init_extra’
util/parse-events.c:695: warning: nested extern declaration of
‘parse_events_lex_init_extra’
util/parse-events.c:699: error: too many arguments to function
‘parse_events__scan_string’
util/parse-events.c:706: error: too many arguments to function
‘parse_events__flush_buffer’
util/parse-events.c:707: error: too many arguments to function
‘parse_events__delete_buffer’
util/parse-events.c:708: error: too many arguments to function
‘parse_events_lex_destroy’
util/parse-events.c: In function ‘parse_events_terms’:
util/parse-events.c:722: error: ‘PE_START_TERMS’ undeclared (first use
in this function)
util/parse-events.c:722: error: (Each undeclared identifier is reported
only once
util/parse-events.c:722: error: for each function it appears in.)
util/parse-events.c: In function ‘parse_events’:
util/parse-events.c:741: error: ‘PE_START_EVENTS’ undeclared (first use
in this function)


-- 
ak@linux.intel.com -- Speaking for myself only

Re: Current perf tool does not compile anymore on RHEL6

[Arnaldo Carvalho de Melo]

Em Tue, Sep 18, 2012 at 10:29:48AM -0700, Andi Kleen escreveu:
> Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA
> 
> Problem started with
> 
> commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4
> Author: Jiri Olsa <jolsa@redhat.com>
> Date:   Fri Jun 15 14:31:40 2012 +0800
> 
>     perf/tool: Add support to reuse event grammar to parse out terms
> 
> 
> Unfortunately needs several other patches reverted too to revert.

That is really, really strange, since I do work primarily on:

[acme@sandy linux]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.3 (Santiago)
[acme@sandy linux]$ rpm -q flex
flex-2.5.35-8.el6.x86_64

And haven't noticed such problem...

- Arnaldo

Re: Current perf tool does not compile anymore on RHEL6

[Jiri Olsa]

On Tue, Sep 18, 2012 at 10:29:48AM -0700, Andi Kleen wrote:
> 
> Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA
> 
> Problem started with
> 
> commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4
> Author: Jiri Olsa <jolsa@redhat.com>
> Date:   Fri Jun 15 14:31:40 2012 +0800
> 
>     perf/tool: Add support to reuse event grammar to parse out terms
> 
> 
> Unfortunately needs several other patches reverted too to revert.

sry for late answer I was out last week,

it's strange since we build 6.3 perf on regular basis,
I'll check..

jirka

Re: Current perf tool does not compile anymore on RHEL6

[Jiri Olsa]

On Mon, Sep 24, 2012 at 12:28:04PM +0200, Jiri Olsa wrote:
> On Tue, Sep 18, 2012 at 10:29:48AM -0700, Andi Kleen wrote:
> > 
> > Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA
> > 
> > Problem started with
> > 
> > commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4
> > Author: Jiri Olsa <jolsa@redhat.com>
> > Date:   Fri Jun 15 14:31:40 2012 +0800
> > 
> >     perf/tool: Add support to reuse event grammar to parse out terms
> > 
> > 
> > Unfortunately needs several other patches reverted too to revert.
> 
> sry for late answer I was out last week,
> 
> it's strange since we build 6.3 perf on regular basis,
> I'll check..
> 
> jirka

hm, it builds ok for me with:

# rpm -qa | egrep "(flex|bison)"
flex-2.5.35-8.el6.x86_64
bison-2.4.1-5.el6.x86_64

Do you still have the issue?

jirka

Re: Current perf tool does not compile anymore on RHEL6

[Arnaldo Carvalho de Melo]

Em Mon, Sep 24, 2012 at 02:05:29PM +0200, Jiri Olsa escreveu:
> On Mon, Sep 24, 2012 at 12:28:04PM +0200, Jiri Olsa wrote:
> > On Tue, Sep 18, 2012 at 10:29:48AM -0700, Andi Kleen wrote:
> > > Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA
> > > 
> > > Problem started with

> > > commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4
> > > Author: Jiri Olsa <jolsa@redhat.com>
> > > Date:   Fri Jun 15 14:31:40 2012 +0800
> > > 
> > >     perf/tool: Add support to reuse event grammar to parse out terms

> > > Unfortunately needs several other patches reverted too to revert.
> > 
> > sry for late answer I was out last week,

> > it's strange since we build 6.3 perf on regular basis,
> > I'll check..
> 
> hm, it builds ok for me with:
> 
> # rpm -qa | egrep "(flex|bison)"
> flex-2.5.35-8.el6.x86_64
> bison-2.4.1-5.el6.x86_64
> 
> Do you still have the issue?

Possibly fixed by a patch by Eric Sandeen, see:

https://lkml.org/lkml/2012/9/20/691

- Arnaldo