Re: [PATCH v1] perf lock contention: skip traceiter functions

Namhyung Kim
2024-03-11T22:29:24Z

On Mon, Mar 11, 2024 at 12:53 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Mon, Mar 11, 2024 at 07:25:16PM +0000, Anne Macedo wrote:
> > Anne Macedo <retpolanne@posteo.net> writes:
> > > Namhyung Kim <namhyung@kernel.org> writes:
> > >> I think it depends on the kernel version and configuration. I remember
> > >> I saw a different symbol on old kernels. But it'd be hard to handle all
> > >> the cases. Let's have a single trace text section in the struct machine
> > >> and use __traceiter_contention_begin only. If it's not found you can
> > >> fallback to trace_contention_begin.
>
> > However, if we fallback to trace_contention_begin, we won't be able to
> > filter out both __traceiter_contention_begin and trace_contention_begin
> > at the same time.
>
> I think for ARM we need to skip both, no? I.e. I agree with Anne.

I haven't tested it on ARM, please go ahead if it is needed.

Thanks,
Namhyung