From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A69C433DB for ; Fri, 22 Jan 2021 00:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F0CC22527 for ; Fri, 22 Jan 2021 00:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726257AbhAVAmV (ORCPT ); Thu, 21 Jan 2021 19:42:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbhAVAmM (ORCPT ); Thu, 21 Jan 2021 19:42:12 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E980C061756 for ; Thu, 21 Jan 2021 16:41:32 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id d4so2278552plh.5 for ; Thu, 21 Jan 2021 16:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version; bh=nOYY3wDFFyUHd+pDNhBfvRcMzwJuLpl+9B6EQmMU4s4=; b=Hq5yPQt0uSuLMkvUcfSinVTM0oyaIiU/GT742c8RJiz0DuX2hcNuRbfUVI70fXVgc4 3MeR0bjPF8I1KaoxHfyFkT2f0idy0I+BOCoqdB7PnswbZ6KZ1NSBXoytcZahn9nrVY3K Nn/neknVhi+QwixHhixtMK5/Hnazt9qelhvZAcZkaOCwLH5GM2babSj8B2g1gXpmYkF7 ZKk/svuOdfuWfSWMaCXgT2+ZV7OxQpCTLJTZagNdZfLbC0SWYX/hxM1qwoTFZ9Myxqb8 46iZWUvr4qSAjYieE2uEL2L53Ysu0OUHu+jOzkxTb+RKYqwgRoTQHfvPR09W5O3OK386 B29g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:mime-version; bh=nOYY3wDFFyUHd+pDNhBfvRcMzwJuLpl+9B6EQmMU4s4=; b=BrOtjpM5/cHIuMvurxCdN2A8mt45un9GateUJ/PP8ESsgEQGN+I2QehIrSIyNhsuKw E7+ZQ9e/M+pVQ+NVYoqqzMONBfZ3UvzaHJWgg52fKljqxOiZENonHm9Yq75ipa2M0XA6 8K3V8HCy6LUO4cyuG1j+HPd7XurVseOBJUJ/RCgXvrIk0CEie8Hmp58Z+21CP1gCdzkJ LEroM87LOxbn07EhNAx2pPpTMKKl6duFPZlftsVmecN8gAQUs5GoRIl5jg5YyLKrKc8i Gs+krgXmKIRjVbzFH8d6h1LK3KI+MsFioThWq2DMFx+RVIexpwPVUpxEbIpVq32HIJap Mc7A== X-Gm-Message-State: AOAM530SmXbXcxGDL22GFSaD8KI3c6fgt4Nl1byibcvvIlk8NUsVJWcx xheNDBVrMG5zG8uF8RRtnUw= X-Google-Smtp-Source: ABdhPJxcEnpd3ryUQH/32oGoW4y7n06Kmp7reDUdXFiXtck9kSbY1/Q8HwcFO1/WA5N7mnQqIYNvmw== X-Received: by 2002:a17:902:b189:b029:dc:4102:4edf with SMTP id s9-20020a170902b189b02900dc41024edfmr1960035plr.80.1611276091406; Thu, 21 Jan 2021 16:41:31 -0800 (PST) Received: from earth-mac.local.gmail.com (219x123x138x129.ap219.ftth.ucom.ne.jp. [219.123.138.129]) by smtp.gmail.com with ESMTPSA id v1sm7499917pjd.26.2021.01.21.16.41.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jan 2021 16:41:30 -0800 (PST) Date: Fri, 22 Jan 2021 09:41:19 +0900 Message-ID: From: Hajime Tazaki To: paullawrence@google.com Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, krisman@collabora.com, chris.obbard@collabora.com, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] um: ubd: Fix crash from option parsing In-Reply-To: <20210119181945.2071053-1-paullawrence@google.com> References: <20210119181945.2071053-1-paullawrence@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/25.3 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, 20 Jan 2021 03:19:45 +0900, Paul Lawrence wrote: > > Below patch will cause NULL ptr dereferences if the optional filenames > are not present. > > Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline) > Signed-off-by: Paul Lawrence This was addressed/fixed by the below patch, though that one doesn't the first "file" variable check. http://lists.infradead.org/pipermail/linux-um/2020-December/000983.html There was another attempt to fix (with the same diff), btw. http://lists.infradead.org/pipermail/linux-um/2021-January/000998.html It seems that the patch is already queued but not upstreamed yet. -- Hajime