* Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]
2013-03-30 19:46 ` Andreas Schwab
@ 2013-04-02 11:19 ` Jon Medhurst (Tixy)
2013-04-02 12:45 ` Prabhakar Lad
2013-04-09 12:14 ` Prabhakar Lad
2 siblings, 0 replies; 8+ messages in thread
From: Jon Medhurst (Tixy) @ 2013-04-02 11:19 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Prabhakar Lad, LAK, linux-kernel, Michal Marek
On Sat, 2013-03-30 at 20:46 +0100, Andreas Schwab wrote:
> "Jon Medhurst (Tixy)" <tixy@linaro.org> writes:
>
> > For builds which succeed I see this order:
> >
> > WRAP arch/arm/include/generated/asm/types.h
> > [...]
> > GEN include/generated/asm-offsets.h
> >
> > and for those which fail:
> >
> > CC scripts/mod/devicetable-offsets.s
> > In file included from include/linux/types.h:5:0,
> > from include/linux/mod_devicetable.h:11,
> > from scripts/mod/devicetable-offsets.c:2:
> > include/uapi/linux/types.h:4:23: fatal error: asm/types.h: No such file or directory
> > [...]
> > WRAP arch/arm/include/generated/asm/types.h
>
> Does that help?
It's rather difficult to be certain as I've only seen it in our daily
automated builds but I forced the failure on my local PC by adding
'sleep 2' to the rules in scripts/Makefile.asm-generic and doing a build
with -j4. Then after applying the below fix I couldn't reproduce the
failure. I'll add the fix to the trees our automated builds use and
report if I see any other issues but I don't anticipate any.
Thanks for looking at this.
> diff --git a/Makefile b/Makefile
> index a5f3203..2a484db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -512,7 +512,8 @@ ifeq ($(KBUILD_EXTMOD),)
> # Carefully list dependencies so we do not try to build scripts twice
> # in parallel
> PHONY += scripts
> -scripts: scripts_basic include/config/auto.conf include/config/tristate.conf
> +scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \
> + asm-generic
> $(Q)$(MAKE) $(build)=$(@)
>
> # Objects we will link into vmlinux / subdirs we need to visit
>
> Andreas.
>
--
Tixy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]
2013-03-30 19:46 ` Andreas Schwab
2013-04-02 11:19 ` Jon Medhurst (Tixy)
@ 2013-04-02 12:45 ` Prabhakar Lad
2013-04-09 12:14 ` Prabhakar Lad
2 siblings, 0 replies; 8+ messages in thread
From: Prabhakar Lad @ 2013-04-02 12:45 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Jon Medhurst (Tixy), LAK, linux-kernel, Michal Marek
Hi Andreas,
On Sun, Mar 31, 2013 at 1:16 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> "Jon Medhurst (Tixy)" <tixy@linaro.org> writes:
>
>> For builds which succeed I see this order:
>>
>> WRAP arch/arm/include/generated/asm/types.h
>> [...]
>> GEN include/generated/asm-offsets.h
>>
>> and for those which fail:
>>
>> CC scripts/mod/devicetable-offsets.s
>> In file included from include/linux/types.h:5:0,
>> from include/linux/mod_devicetable.h:11,
>> from scripts/mod/devicetable-offsets.c:2:
>> include/uapi/linux/types.h:4:23: fatal error: asm/types.h: No such file or directory
>> [...]
>> WRAP arch/arm/include/generated/asm/types.h
>
> Does that help?
>
> diff --git a/Makefile b/Makefile
> index a5f3203..2a484db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -512,7 +512,8 @@ ifeq ($(KBUILD_EXTMOD),)
> # Carefully list dependencies so we do not try to build scripts twice
> # in parallel
> PHONY += scripts
> -scripts: scripts_basic include/config/auto.conf include/config/tristate.conf
> +scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \
> + asm-generic
> $(Q)$(MAKE) $(build)=$(@)
>
> # Objects we will link into vmlinux / subdirs we need to visit
>
This works thanks for the patch!
Reported-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Tested-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]
2013-03-30 19:46 ` Andreas Schwab
2013-04-02 11:19 ` Jon Medhurst (Tixy)
2013-04-02 12:45 ` Prabhakar Lad
@ 2013-04-09 12:14 ` Prabhakar Lad
2013-04-09 17:57 ` [PATCH] kbuild: generate generic headers before recursing into scripts Andreas Schwab
2 siblings, 1 reply; 8+ messages in thread
From: Prabhakar Lad @ 2013-04-09 12:14 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Jon Medhurst (Tixy), LAK, linux-kernel, Michal Marek
Hi Andreas
On Sun, Mar 31, 2013 at 1:16 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> "Jon Medhurst (Tixy)" <tixy@linaro.org> writes:
>
>> For builds which succeed I see this order:
>>
>> WRAP arch/arm/include/generated/asm/types.h
>> [...]
>> GEN include/generated/asm-offsets.h
>>
>> and for those which fail:
>>
>> CC scripts/mod/devicetable-offsets.s
>> In file included from include/linux/types.h:5:0,
>> from include/linux/mod_devicetable.h:11,
>> from scripts/mod/devicetable-offsets.c:2:
>> include/uapi/linux/types.h:4:23: fatal error: asm/types.h: No such file or directory
>> [...]
>> WRAP arch/arm/include/generated/asm/types.h
>
> Does that help?
>
> diff --git a/Makefile b/Makefile
> index a5f3203..2a484db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -512,7 +512,8 @@ ifeq ($(KBUILD_EXTMOD),)
> # Carefully list dependencies so we do not try to build scripts twice
> # in parallel
> PHONY += scripts
> -scripts: scripts_basic include/config/auto.conf include/config/tristate.conf
> +scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \
> + asm-generic
> $(Q)$(MAKE) $(build)=$(@)
>
> # Objects we will link into vmlinux / subdirs we need to visit
>
Whats the status of it ?
Regards,
--Prabhakar
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] kbuild: generate generic headers before recursing into scripts
2013-04-09 12:14 ` Prabhakar Lad
@ 2013-04-09 17:57 ` Andreas Schwab
2013-04-10 4:39 ` Prabhakar Lad
2013-04-10 7:56 ` Michal Marek
0 siblings, 2 replies; 8+ messages in thread
From: Andreas Schwab @ 2013-04-09 17:57 UTC (permalink / raw)
To: Prabhakar Lad; +Cc: Jon Medhurst (Tixy), LAK, linux-kernel, Michal Marek
The headers are now needed inside scripts/mod since 6543bec
("mod/file2alias: make modalias generation safe for cross compiling").
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
Prabhakar Lad <prabhakar.csengg@gmail.com> writes:
> Whats the status of it ?
I think it has sufficiently been tested by now.
Andreas.
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6db672b..11157bd 100644
--- a/Makefile
+++ b/Makefile
@@ -513,7 +513,8 @@ ifeq ($(KBUILD_EXTMOD),)
# Carefully list dependencies so we do not try to build scripts twice
# in parallel
PHONY += scripts
-scripts: scripts_basic include/config/auto.conf include/config/tristate.conf
+scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \
+ asm-generic
$(Q)$(MAKE) $(build)=$(@)
# Objects we will link into vmlinux / subdirs we need to visit
--
1.8.2.1
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] kbuild: generate generic headers before recursing into scripts
2013-04-09 17:57 ` [PATCH] kbuild: generate generic headers before recursing into scripts Andreas Schwab
@ 2013-04-10 4:39 ` Prabhakar Lad
2013-04-10 7:56 ` Michal Marek
1 sibling, 0 replies; 8+ messages in thread
From: Prabhakar Lad @ 2013-04-10 4:39 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Jon Medhurst (Tixy), LAK, linux-kernel, Michal Marek
On Tue, Apr 9, 2013 at 11:27 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> The headers are now needed inside scripts/mod since 6543bec
> ("mod/file2alias: make modalias generation safe for cross compiling").
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Reported-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Tested-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar
> ---
> Prabhakar Lad <prabhakar.csengg@gmail.com> writes:
>
>> Whats the status of it ?
>
> I think it has sufficiently been tested by now.
>
> Andreas.
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6db672b..11157bd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -513,7 +513,8 @@ ifeq ($(KBUILD_EXTMOD),)
> # Carefully list dependencies so we do not try to build scripts twice
> # in parallel
> PHONY += scripts
> -scripts: scripts_basic include/config/auto.conf include/config/tristate.conf
> +scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \
> + asm-generic
> $(Q)$(MAKE) $(build)=$(@)
>
> # Objects we will link into vmlinux / subdirs we need to visit
> --
> 1.8.2.1
>
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] kbuild: generate generic headers before recursing into scripts
2013-04-09 17:57 ` [PATCH] kbuild: generate generic headers before recursing into scripts Andreas Schwab
2013-04-10 4:39 ` Prabhakar Lad
@ 2013-04-10 7:56 ` Michal Marek
1 sibling, 0 replies; 8+ messages in thread
From: Michal Marek @ 2013-04-10 7:56 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Prabhakar Lad, Jon Medhurst (Tixy), LAK, linux-kernel
On 9.4.2013 19:57, Andreas Schwab wrote:
> The headers are now needed inside scripts/mod since 6543bec
> ("mod/file2alias: make modalias generation safe for cross compiling").
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> Prabhakar Lad <prabhakar.csengg@gmail.com> writes:
>
>> Whats the status of it ?
>
> I think it has sufficiently been tested by now.
Thanks a lot, I added it to kbuild.git#rc-fixes.
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread