Re: [PATCH 1/2] ASoC: codec: Remove pxa2xx-ac97.c

[Robert Jarzmik <robert.jarzmik@free.fr>]

"Arnd Bergmann" <arnd@arndb.de> writes:

> On Thu, Sep 18, 2025, at 07:44, Peng Fan wrote:
>> With commit ce79f3a1ad5f ("ARM: pxa: prune unused device support") and
>> commit 2548e6c76ebf ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource"), there
>> is no 'pxa2xx-ac97' platform device created by machine level code, so this
>> driver could be removed.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>  sound/arm/Kconfig       |  10 --
>>  sound/arm/Makefile      |   3 -
>>  sound/arm/pxa2xx-ac97.c | 286 ------------------------------------------------
>>  3 files changed, 299 deletions(-)
>
> I think you are right, I was sure there was still a way to use this
> driver either as part of sound/soc/pxa/*, or as an alternative,
> but now I don't see how.
>
> If we do this, I think we should just merge pxa2xx-pcm-lib.c and
> snd-pxa2xx-lib.c into the respective callers in the sound/soc/pxa/
> driver.
>
> Robert, can you confirm?
Hi Arnd,

That'a a way of doing it, yet I would have chosen another path.
I would have taken all the code out of sound/arm/pxa2xx-pcm-lib.c, and
injected it into sound/soc/pxa2xx-pcm.c The reason is that the PCM code
is used across AC97, I2S and SSP. You would have to duplicate that if
you were to inject it to its callers.

I would also see with a keen eye the removal of sound/arm/*. Unless I'm
mistaken, this code only works in platform_data environments. And if you
want to leave only DT code, well ... the long term should be to remove
this part.

The code in sound/soc/pxa provides another access to the same
functionality (ie. sound on pxa platforms), and is DT compliant.

On a personal note, I only ever used sound/soc/pxa/* in all my boards,
and never arm/pxa/*. I'm not aware of any remaining users of sound/arm/*. 

Cheers.

--
Robert