From: Kevin Hilman <khilman@baylibre.com>
To: "Michał Zegan" <webczat@webczatnet.pl>
Cc: Carlo Caione <carlo@caione.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init
Date: Fri, 17 Feb 2017 11:44:52 -0800 [thread overview]
Message-ID: <m2k28o61qj.fsf@baylibre.com> (raw)
In-Reply-To: <20170216145222.1577-2-webczat@webczatnet.pl> ("Michał Zegan"'s message of "Thu, 16 Feb 2017 15:52:21 +0100")
Michał Zegan <webczat@webczatnet.pl> writes:
> At the end of function meson_mmc_clk_init, the cfg_div clock was
> prepared, enabled and configured, but then immediately disabled due to bogus if statements.
> That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning.
> Fix that by changing the code to disable clock only when it failed to be configured.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
I believe this one is not needed any more after Heiner's cleanups?
Kevin
next prev parent reply other threads:[~2017-02-17 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 14:52 [PATCH 0/2] mmc: meson-gx: fix module unloading Michał Zegan
2017-02-16 14:52 ` [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init Michał Zegan
2017-02-17 19:44 ` Kevin Hilman [this message]
2017-02-17 19:49 ` Michał Zegan
2017-02-16 14:52 ` [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Michał Zegan
2017-02-17 19:47 ` Kevin Hilman
2017-02-17 19:50 ` Michał Zegan
2017-02-17 23:03 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k28o61qj.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=carlo@caione.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=webczat@webczatnet.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox