From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934847AbdBQTo4 (ORCPT ); Fri, 17 Feb 2017 14:44:56 -0500 Received: from mail-pg0-f53.google.com ([74.125.83.53]:33858 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335AbdBQToy (ORCPT ); Fri, 17 Feb 2017 14:44:54 -0500 From: Kevin Hilman To: =?utf-8?Q?Micha=C5=82?= Zegan Cc: Carlo Caione , Ulf Hansson , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init Organization: BayLibre References: <20170216145222.1577-1-webczat@webczatnet.pl> <20170216145222.1577-2-webczat@webczatnet.pl> Date: Fri, 17 Feb 2017 11:44:52 -0800 In-Reply-To: <20170216145222.1577-2-webczat@webczatnet.pl> (=?utf-8?Q?=22M?= =?utf-8?Q?icha=C5=82?= Zegan"'s message of "Thu, 16 Feb 2017 15:52:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1HJjHIq002018 Michał Zegan writes: > At the end of function meson_mmc_clk_init, the cfg_div clock was > prepared, enabled and configured, but then immediately disabled due to bogus if statements. > That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning. > Fix that by changing the code to disable clock only when it failed to be configured. > > Signed-off-by: Michał Zegan I believe this one is not needed any more after Heiner's cleanups? Kevin