From: Peter Osterlund <petero2@telia.com>
To: linux-kernel@vger.kernel.org
Cc: Vojtech Pavlik <vojtech@suse.cz>,
Dmitry Torokhov <dtor_core@ameritech.net>,
Peter Berg Larsen <pebl@math.ku.dk>
Subject: [PATCH] Fix synaptics driver for PowerPro C 3:16
Date: 11 Nov 2003 21:32:18 +0100 [thread overview]
Message-ID: <m2llqmy7cd.fsf@p4.localdomain> (raw)
Hi!
A user reported that the synaptics touchpad driver didn't work on his
PowerPro C 3:16 laptop. Some debugging revealed that the patch below
is necessary to make the driver compatible with his touchpad.
For some reason bit 3 in byte 1 and 4 in the synaptics packets are set
to 1, which fails because the driver follows the documentation which
says that the bit is 0.
Hardware properties: (reported by synclient -h)
Model Id = 009d48b1
Capabilities = 00904713
Identity = 00084715
With this patch, the touchpad works as expected. As far as I can see,
this patch can not break anything for other touchpads, so it should be
safe. Does anyone see a problem with this patch?
--- linux/drivers/input/mouse/synaptics.c.old 2003-11-11 20:41:15.000000000 +0100
+++ linux/drivers/input/mouse/synaptics.c 2003-11-11 20:41:29.000000000 +0100
@@ -581,7 +581,7 @@
switch (psmouse->pktcnt) {
case 1:
- if (newabs ? ((data & 0xC8) != 0x80) : ((data & 0xC0) != 0xC0)) {
+ if (newabs ? ((data & 0xC0) != 0x80) : ((data & 0xC0) != 0xC0)) {
printk(KERN_WARNING "Synaptics driver lost sync at 1st byte\n");
goto bad_sync;
}
@@ -593,7 +593,7 @@
}
break;
case 4:
- if (newabs ? ((data & 0xC8) != 0xC0) : ((data & 0xC0) != 0x80)) {
+ if (newabs ? ((data & 0xC0) != 0xC0) : ((data & 0xC0) != 0x80)) {
printk(KERN_WARNING "Synaptics driver lost sync at 4th byte\n");
goto bad_sync;
}
--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
next reply other threads:[~2003-11-11 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-11 20:32 Peter Osterlund [this message]
2003-11-11 21:55 ` [PATCH] Fix synaptics driver for PowerPro C 3:16 Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2llqmy7cd.fsf@p4.localdomain \
--to=petero2@telia.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pebl@math.ku.dk \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox