From: Peter Osterlund <petero2@telia.com>
To: "Garst R. Reese" <reese@isn.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
torvalds@transmeta.com, Alexander Viro <viro@math.psu.edu>
Subject: Re: 2.4.10-pre5
Date: 08 Sep 2001 12:36:56 +0200 [thread overview]
Message-ID: <m2lmjq7yuv.fsf@ppro.localdomain> (raw)
In-Reply-To: <3B99A8C2.56E88CE3@isn.net>
In-Reply-To: <3B99A8C2.56E88CE3@isn.net>
"Garst R. Reese" <reese@isn.net> writes:
> Garstmake[2]: Entering directory `/usr/src/linux/drivers/block'
> gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i586 -DMODULE -c -o rd.o rd.c
> rd.c: In function `rd_ioctl':
> rd.c:262: invalid type argument of `->'
> rd.c: In function `rd_cleanup':
> rd.c:375: too few arguments to function `blkdev_put'
> make[2]: *** [rd.o] Error 1
> make[2]: Leaving directory `/usr/src/linux/drivers/block'
> make[1]: *** [_modsubdir_block] Error 2
> make[1]: Leaving directory `/usr/src/linux/drivers'
> make: *** [_mod_drivers] Error 2
> Command exited with non-zero status 2
This patch seems to work:
--- linux/drivers/block/rd.c.orig Sat Sep 8 11:58:19 2001
+++ linux/drivers/block/rd.c Sat Sep 8 12:21:50 2001
@@ -259,7 +259,7 @@
/* special: we want to release the ramdisk memory,
it's not like with the other blockdevices where
this ioctl only flushes away the buffer cache. */
- if ((atomic_read(rd_bdev[minor]->bd_openers) > 2))
+ if ((atomic_read(&rd_bdev[minor]->bd_openers) > 2))
return -EBUSY;
destroy_buffers(inode->i_rdev);
rd_blocksizes[minor] = 0;
@@ -372,7 +372,7 @@
struct block_device *bdev = rd_bdev[i];
rd_bdev[i] = NULL;
if (bdev) {
- blkdev_put(bdev);
+ blkdev_put(bdev, BDEV_FILE);
bdput(bdev);
}
destroy_buffers(MKDEV(MAJOR_NR, i));
--
Peter Österlund petero2@telia.com
Sköndalsvägen 35 http://w1.894.telia.com/~u89404340
S-128 66 Sköndal +46 8 942647
Sweden
next prev parent reply other threads:[~2001-09-08 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-08 5:12 2.4.10-pre5 Garst R. Reese
2001-09-08 6:14 ` 2.4.10-pre5 Kingsley Foreman
2001-09-08 6:46 ` 2.4.10-pre5 Josh McKinney
2001-09-08 8:19 ` 2.4.10-pre5 Nicholas Knight
2001-09-08 9:32 ` 2.4.10-pre5 Eyal Lebedinsky
2001-09-08 13:05 ` 2.4.10-pre5 Alan Cox
2001-09-08 22:03 ` 2.4.10-pre5 Alessandro Suardi
2001-09-09 4:05 ` 2.4.10-pre5 Josh McKinney
2001-09-09 4:14 ` 2.4.10-pre5 Steven Walter
2001-09-09 11:48 ` 2.4.10-pre5 (and gcc-3) Ken Moffat
2001-09-09 21:22 ` compiling kernel with gcc-3 (was: 2.4.10-pre5) Alessandro Suardi
2001-09-08 10:36 ` Peter Osterlund [this message]
2001-09-08 12:57 ` 2.4.10-pre5 Garst R. Reese
2001-09-09 5:30 ` 2.4.10-pre5/pre6 Garst R. Reese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lmjq7yuv.fsf@ppro.localdomain \
--to=petero2@telia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reese@isn.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox