From: Andi Kleen <andi@firstfloor.org>
To: "Jan Beulich" <JBeulich@suse.com>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86-64: cleanup some assembly entry points
Date: Tue, 29 Nov 2011 12:59:29 -0800 [thread overview]
Message-ID: <m2mxbelk5q.fsf@firstfloor.org> (raw)
In-Reply-To: <4ED4CEEA020000780006407D@nat28.tlf.novell.com> (Jan Beulich's message of "Tue, 29 Nov 2011 11:24:10 +0000")
"Jan Beulich" <JBeulich@suse.com> writes:
> The compatibility mode ptregs entry points for one can make use of the
> GLOBAL() macro, and should be suitably aligned. Their shared
> continuation point (ia32_ptregs_common) otoh doesn't need to be global
> at all, but should continue to be properly aligned.
FWIW I reviewed all the patches and they look good to me
(except for the tricky THREAD_INFO patch, sorry)
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-11-29 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 11:24 [PATCH] x86-64: cleanup some assembly entry points Jan Beulich
2011-11-29 20:59 ` Andi Kleen [this message]
2011-12-05 18:02 ` [tip:x86/asm] x86-64: Cleanup " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mxbelk5q.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox