From: Chris Ball <cjb@laptop.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
patches@linaro.org
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h
Date: Sun, 14 Aug 2011 23:54:36 -0400 [thread overview]
Message-ID: <m2mxfbmirn.fsf@bob.laptop.org> (raw)
In-Reply-To: <1313375298-18546-1-git-send-email-shawn.guo@linaro.org> (Shawn Guo's message of "Mon, 15 Aug 2011 10:28:18 +0800")
Hi Shawn,
On Sun, Aug 14 2011, Shawn Guo wrote:
> There are following warning and error when compiling the driver.
> The patch adds the missing inclusion of linux/module.h to fix them.
>
> drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has
> no type or storage class
Pushed to mmc-next for 3.1. I don't see these on my imx build with
CONFIG_MMC_SDHCI_ESDHC_IMX=m, so it'd be useful to see your .config
so that I'm able to reproduce in future.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-08-15 3:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 2:28 [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h Shawn Guo
2011-08-15 3:54 ` Chris Ball [this message]
2011-08-15 5:35 ` Shawn Guo
2011-08-15 5:46 ` Stephen Rothwell
2011-08-15 5:57 ` Chris Ball
2011-08-15 6:05 ` Shawn Guo
2011-08-15 6:44 ` Stephen Rothwell
2011-08-15 5:50 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mxfbmirn.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox