From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756546AbcIAVFx (ORCPT ); Thu, 1 Sep 2016 17:05:53 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36024 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756477AbcIAVFv (ORCPT ); Thu, 1 Sep 2016 17:05:51 -0400 From: Kevin Hilman To: Neil Armstrong Cc: carlo@caione.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: meson-gxbb: Add support for the Nexbox A95X Board Organization: BayLibre References: <1471951370-29269-1-git-send-email-narmstrong@baylibre.com> Date: Thu, 01 Sep 2016 14:05:47 -0700 In-Reply-To: <1471951370-29269-1-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 23 Aug 2016 13:22:50 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u81L5wwT014565 Hi Neil, Neil Armstrong writes: > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 79 ++++++++++++++++++++++ > 2 files changed, 80 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts Can we add this patch to your gx/gxbb/gxl breakup series? Some other minor nits below... > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 47ec703..2c50439 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-p201.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-pro.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-meta.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-telos.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts > new file mode 100644 > index 0000000..c418bd7 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts > @@ -0,0 +1,79 @@ > +/* > + * Copyright (c) 2016 Andreas Färber > + * Copyright (c) 2016 BayLibre, Inc. > + * Author: Neil Armstrong > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > + > +#include "meson-gxbb.dtsi" > +#include > + > +/ { > + compatible = "nexbox,a95x", "amlogic,meson-gxbb"; >>From checkpatch: ARNING: DT compatible string "nexbox,a95x" appears un-documented -- check ./Documentation/devicetree/bindings/ #78: FILE: arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts:51: + compatible = "nexbox,a95x", "amlogic,meson-gxbb"; WARNING: DT compatible string vendor "nexbox" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt #78: FILE: arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts:51: + compatible = "nexbox,a95x", "amlogic,meson-gxbb"; > + model = "NEXBOX A95X"; > + And some trailing whitespace here. > + aliases { > + serial0 = &uart_AO; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > +}; > + > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +ðmac { > + status = "okay"; > + pinctrl-0 = <ð_pins>; > + pinctrl-names = "default"; > +}; > + Kevin