From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <robert.richter@amd.com>,
Ingo Molnar <mingo@kernel.org>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: Introduce function to report unsupported syscall attribute flags
Date: Wed, 12 Sep 2012 07:26:38 -0700 [thread overview]
Message-ID: <m2oblbz59d.fsf@firstfloor.org> (raw)
In-Reply-To: <1347448843.15764.3.camel@twins> (Peter Zijlstra's message of "Wed, 12 Sep 2012 13:20:43 +0200")
Peter Zijlstra <peterz@infradead.org> writes:
> On Wed, 2012-09-12 at 13:01 +0200, Robert Richter wrote:
>> + if (notsup)
>> + pr_warn("perf: unsupported attribute flags: %016llx\n", notsup);
>
> This is a dmesg DoS..
>
> I'm also not sure dmesg is the right way.. could we not somehow change
> the attrs to provide better diagnostic?
Have a output argument for a string, that is then printed by the user tool?
I agree it's a problem today, i usually have to resort to ftrace to
figure out what'swrong.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-09-12 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 11:01 [PATCH] perf: Introduce function to report unsupported syscall attribute flags Robert Richter
2012-09-12 11:20 ` Peter Zijlstra
2012-09-12 13:02 ` Robert Richter
2012-09-12 14:26 ` Andi Kleen [this message]
2012-09-12 14:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2oblbz59d.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox