From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4D73502A8 for ; Tue, 3 Mar 2026 17:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772557927; cv=none; b=ovK4j4BgM5E+CYJPfAwfUDgFqjnN2q8mpMhpb53W8Q4LMh2MWbE4XE0Gd6ekTn4Z3LrSyLriFzmwzyQ/GoskcjiqdlXIMTNGNBY7AeMAsEHjTWJ8GRpu5GBD60LfoqXFz1ZqEYpnaB4X00sMK8Sh3gg/KR5ibn6nsFDNg/KJluk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772557927; c=relaxed/simple; bh=9nLva9P5/VWHarj0KXYmdTzbY5QXS6CfRlsKPl23pkE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hBRaqMqO0s7KfwHEongVyjSCHQgGWF5Xsthmdf0KXGu1FwhFSoI7KEoUBSXQyV1qMwo+SvSyQWOX2YZNl5Cqq/BHQ3qvOXeHvjh+4zubAv4YoMRgZcueHYjjsAzxidgASOFDv1ZheIyM6eH6UG78koLM4u6z5y6xY7BK94JfKlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RXHiILf8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RXHiILf8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48375f10628so40004705e9.1 for ; Tue, 03 Mar 2026 09:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772557925; x=1773162725; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NDcMXg9OsPUr76p7RQkmkHIW6zImJV9RKLYzFZeRjCs=; b=RXHiILf8QsmFdCOffqTWVMwTZU2F2/q5ZB5WkjEkzJzGDsz7FpmHhd8qMjY0OGM0dt zOCeYlZcr8bJXG90FUid8UG1AZfodA81WgiY0pMrahGFA6GCbRYthzuI9L7VxCv3oTLO srxQxab4QYav92BGABK1Dtu7OHJgBgSPXqIngKKl6h736tDtdazzUFrM/1ATmhgKzYdK ftHX8Q08CnN1mbxZPLRv8S5rL2U/NAIenJTVJPCWitlp0qEjJXcF9NGSkFRpxGiut3pe vn7hvXgaVG/1zhlqyd7sTKno6ih7+lZRjegKfEoSoc+Oxa/tIAfQ1MG/eA3g2qFdqaa/ 27dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772557925; x=1773162725; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NDcMXg9OsPUr76p7RQkmkHIW6zImJV9RKLYzFZeRjCs=; b=KV1+tXTZKKcamJa1868UOBBA0XOQ1qX9kxN2eZkNzzu9kH3am/nUA6o6gk0jXQqcwp OtgKHWLET+qva+veBcH5SE8Ko3OzF/SZVs27bBVfszrpgU7pkUxC3bisH3C3pJU2fVmw rEqGaqrzZ7GiHl5mh4On7hZWgsofjegKN0Erejz/5Xin2F2MuEc/LL/WgF+WbdtjL0t9 6kfd3F/Hg7EH5VSzTwskdHcoMH0zCFmDQP9yn/KBuThV94OmIoY4Fe6QA3irpDjYJukN 8qYBdwxptZQb00GwgxIVLalL1d8FE6vpZAIx0/ZUufJEtSLKAnIjimvKkH7ctOyasadC WsiA== X-Gm-Message-State: AOJu0YzXoepmrEJW8bGOFf7KX7UCIPAu4rorpAxtP7OxVoPSXcsZDMCt pDOgp5DSe5kVRHjg+ahiimh0l7F2KLwUA+hlegpi+JznZhgz6nCC0vLQ X-Gm-Gg: ATEYQzxBKI20ukp3fML7S4nTkh3joog8U/H4g2C2gbWKIB6tRQzvLUb6VS5QVM6FDj8 V5BBH6wsnWZ/xBolDFYcTUzABrOkwC/YL2iNSqiX5oASkFQfxbkZbjwVmJ2WDQvjZkWbcxTJUIR YRJQKH220inPRnjLlkfxnhsDv0sj8KN5/VWipJLfH+wzJrTj1h9MnpHtXEqrGJBaSeoFmgdQd0b YIgwIeJt3qKmUnfPGOW0k63sSJHg4jMRshppeB6b3q18P3cQD0zJPSfcS/8TJyctpoLoQL0DNWV uYitSoVCeTy6na5p8fSfqzBNUYW+1K9gAKz3XeVlpONsdKX6aCb3v99S2YHzqK6J5+RnC1TyF0R iEATH0RPY1fHS+bTgnly8y7TaKjJNaB3r+hHmC++eBEXOpnKh0BbfqKdYNGWUlaOtfHYGZr/AwL HaFqHH2xkIvOHIMraG7F2yQdb8Dtyw4V5Qeo+2JP05p1ib72hwrIHhp+fehFWx1gEt7cnHtRA03 nE9Tf068zb6BdqwmVgxY5l6AespLw== X-Received: by 2002:a05:600c:3b02:b0:480:3a71:92b2 with SMTP id 5b1f17b1804b1-483c9bedac6mr284130175e9.26.1772557924895; Tue, 03 Mar 2026 09:12:04 -0800 (PST) Received: from localhost (p200300f6f73f480088af5af6c509d4b1.dip0.t-ipconnect.de. [2003:f6:f73f:4800:88af:5af6:c509:d4b1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48512654d91sm20148755e9.2.2026.03.03.09.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 09:12:04 -0800 (PST) From: Johannes Thumshirn To: Filip Jensen Cc: linux-kernel@vger.kernel.org, Jose Javier Rodriguez Barbarin Subject: Re: [PATCH v2 1/2] mcb: Use more than the first bar in pci devices In-Reply-To: <20260302134703.29913-2-dev-Felipe.Jensen@duagon.com> (Filip Jensen's message of "Mon, 2 Mar 2026 14:47:02 +0100") References: <20260302134703.29913-1-dev-Felipe.Jensen@duagon.com> <20260302134703.29913-2-dev-Felipe.Jensen@duagon.com> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Tue, 03 Mar 2026 18:12:03 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Filip Jensen @ 2026-03-02 14:47 : > +static int chameleon_get_bar(void __iomem **base, struct chameleon_bar **cb, > + struct device *dev) > { > struct chameleon_bar *c; > int bar_count; > __le32 reg; > u32 dtype; > + struct pci_dev *pdev; Sorry for not having noticed this in v1 but this... > /* > * For those devices which are not connected > @@ -153,12 +155,15 @@ static int chameleon_get_bar(void __iomem **base, phys_addr_t mapbase, > chameleon_parse_bar(*base, c, bar_count); > *base += BAR_DESC_SIZE(bar_count); > } else { can be declared here, as it's not used outside of this block. > - c = kzalloc_obj(struct chameleon_bar); > + pdev = to_pci_dev(dev); > + bar_count = PCI_STD_NUM_BARS; > + c = kzalloc_objs(struct chameleon_bar, bar_count); > if (!c) > return -ENOMEM; > - > - bar_count = 1; > - c->addr = mapbase; > + for (int i = 0; i < bar_count; ++i) { > + c[i].addr = pci_resource_start(pdev, i); > + c[i].size = pci_resource_len(pdev, i); > + } > }