From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
peterz@infradead.org, mingo@elte.hu, dsahern@gmail.com,
robert.richter@amd.com
Subject: Re: [PATCH] perf: make perf.data more self-descriptive (v5)
Date: Thu, 22 Sep 2011 14:20:43 -0700 [thread overview]
Message-ID: <m2pqisjmtw.fsf@firstfloor.org> (raw)
In-Reply-To: <20110922123128.GA9761@quad> (Stephane Eranian's message of "Thu, 22 Sep 2011 14:31:28 +0200")
Stephane Eranian <eranian@google.com> writes:
> The goal of this patch is to include more information
> about the host environment into the perf.data so it is
> more self-descriptive. Overtime, profiles are captured
> on various machines and it becomes hard to track what
> was recorded, on what machine and when.
I read it near completely.
The only weird thing were the .byte coded push/pops
in CPUID.
Also the /proc parser doesn't seem very robust,
e.g. strstr is not a good way to check for a field.
And the code reading /proc lines with fgets should
likely use getline()
Then the bswap code would be much nicer inside a macro.
Other than that it looks good.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-09-22 21:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 12:31 [PATCH] perf: make perf.data more self-descriptive (v5) Stephane Eranian
2011-09-22 15:35 ` David Ahern
2011-09-22 15:40 ` Stephane Eranian
2011-09-22 15:48 ` David Ahern
2011-09-22 21:20 ` Andi Kleen [this message]
2011-09-22 21:25 ` Stephane Eranian
2011-09-23 3:26 ` Andi Kleen
2011-09-23 6:28 ` Stephane Eranian
2011-09-23 6:40 ` Pekka Enberg
2011-09-23 7:31 ` Stephane Eranian
2011-09-23 8:03 ` Pekka Enberg
2011-09-23 9:04 ` Stephane Eranian
2011-09-23 9:17 ` Pekka Enberg
2011-09-23 13:36 ` David Ahern
[not found] ` <CABPqkBTuc_jowJx0PqPPhcCuj6B5dqRaQNiZWiyhhHMN+NkLYg@mail.gmail.com>
2011-09-23 14:09 ` David Ahern
2011-09-23 14:22 ` Stephane Eranian
2011-09-23 22:13 ` Valdis.Kletnieks
2011-09-23 10:13 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pqisjmtw.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox