Re: [linux-usb-devel] 2.5.40 panic in uhci-hcd

[Peter Osterlund <petero2@telia.com>]

Johannes Erdfelt <johannes@erdfelt.com> writes:

> On Wed, Oct 16, 2002, Peter Osterlund <petero2@telia.com> wrote:
> > 
> > The problem is back in 2.5.43, although it doesn't happen on every
> > boot. I think I first saw this problem in 2.5.35.
> > 
> > The oops looks the same as usual. The oops happens because urb->hcpriv
> > is NULL in uhci_result_control() so the list_empty() check oopses.
> > 
> > At the end of uhci_urb_enqueue() this code
> > 
> > 	if (ret != -EINPROGRESS) {
> > 		uhci_destroy_urb_priv (uhci, urb);
> > 		return ret;
> > 	}
> > 
> > appears to be calling uhci_destroy_urb_priv() without having acquired
> > the urb_list_lock. Can this be the cause of my problem?
> 
> Have you tried this patch? It's in Greg's BK tree, but hasn't been
> picked up by Linus yet.

I applied it to 2.5.39 (which always died at boot before this patch)
and now it boots without problems, so this looks like the correct fix
for my problem. Thanks.

-- 
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340