public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Sekhar Nori <nsekhar@ti.com>,
	Patrick Titiano <ptitiano@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Alexandre Bailon <abailon@baylibre.com>,
	David Lechner <david@lechnology.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Lad Prabhakar <prabhakar.csengg@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 09/10] media: vpif: use a configurable i2c_adapter_id for vpif display
Date: Tue, 07 Feb 2017 10:16:44 -0800	[thread overview]
Message-ID: <m2r339kgs3.fsf@baylibre.com> (raw)
In-Reply-To: <1486485683-11427-10-git-send-email-bgolaszewski@baylibre.com> (Bartosz Golaszewski's message of "Tue, 7 Feb 2017 17:41:22 +0100")

Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:

> The vpif display driver uses a static i2c adapter ID of 1 but on the
> da850-evm board in DT boot mode the i2c adapter ID is actually 0.
>
> Make the adapter ID configurable like it already is for vpif capture.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  arch/arm/mach-davinci/board-da850-evm.c       | 1 +
>  drivers/media/platform/davinci/vpif_display.c | 2 +-
>  include/media/davinci/vpif_types.h            | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index e5d4ded..fe0bfa7 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
> @@ -1290,6 +1290,7 @@ static struct vpif_display_config da850_vpif_display_config = {
>  		.output_count = ARRAY_SIZE(da850_ch0_outputs),
>  	},
>  	.card_name    = "DA850/OMAP-L138 Video Display",
> +	.i2c_adapter_id = 1,
>  };
>  
>  static __init void da850_vpif_init(void)
> diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c
> index 50c3073..7e5cf99 100644
> --- a/drivers/media/platform/davinci/vpif_display.c
> +++ b/drivers/media/platform/davinci/vpif_display.c
> @@ -1287,7 +1287,7 @@ static __init int vpif_probe(struct platform_device *pdev)
>  	}
>  
>  	if (!vpif_obj.config->asd_sizes) {
> -		i2c_adap = i2c_get_adapter(1);
> +		i2c_adap = i2c_get_adapter(vpif_obj.config->i2c_adapter_id);
>  		for (i = 0; i < subdev_count; i++) {
>  			vpif_obj.sd[i] =
>  				v4l2_i2c_new_subdev_board(&vpif_obj.v4l2_dev,
> diff --git a/include/media/davinci/vpif_types.h b/include/media/davinci/vpif_types.h
> index 4282a7d..0c72b46 100644
> --- a/include/media/davinci/vpif_types.h
> +++ b/include/media/davinci/vpif_types.h
> @@ -57,6 +57,7 @@ struct vpif_display_config {
>  	int (*set_clock)(int, int);
>  	struct vpif_subdev_info *subdevinfo;
>  	int subdev_count;
> +	int i2c_adapter_id;
>  	struct vpif_display_chan_config chan_config[VPIF_DISPLAY_MAX_CHANNELS];
>  	const char *card_name;
>  	struct v4l2_async_subdev **asd;	/* Flat array, arranged in groups */

  reply	other threads:[~2017-02-07 18:16 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 16:41 [PATCH 00/10] ARM: davinci: add vpif display support Bartosz Golaszewski
2017-02-07 16:41 ` [PATCH 01/10] media: dt-bindings: vpif: fix whitespace errors Bartosz Golaszewski
2017-02-15 22:01   ` Rob Herring
2017-02-07 16:41 ` [PATCH 02/10] ARM: dts: da850-evm: " Bartosz Golaszewski
2017-02-13 18:28   ` Kevin Hilman
2017-02-13 18:35   ` Kevin Hilman
2017-02-13 21:01     ` Kevin Hilman
2017-02-14  6:30       ` Sekhar Nori
2017-02-07 16:41 ` [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski
2017-02-15 22:03   ` Rob Herring
2017-02-15 22:08   ` Rob Herring
2017-02-16  7:32     ` Laurent Pinchart
2017-02-16 16:06     ` Bartosz Golaszewski
2017-02-07 16:41 ` [PATCH 04/10] ARM: dts: da850-evm: add the output port to the vpif node Bartosz Golaszewski
2017-02-07 16:41 ` [PATCH 05/10] ARM: dts: da850: add vpif video display pins Bartosz Golaszewski
2017-02-07 16:41 ` [PATCH 06/10] ARM: davinci_all_defconfig: enable VPIF display modules Bartosz Golaszewski
2017-02-07 16:41 ` [PATCH 07/10] ARM: davinci: fix a whitespace error Bartosz Golaszewski
2017-02-13 18:36   ` Kevin Hilman
2017-02-13 21:04     ` Kevin Hilman
2017-02-07 16:41 ` [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm Bartosz Golaszewski
2017-02-07 18:21   ` Kevin Hilman
2017-02-09 15:23     ` Sekhar Nori
2017-02-09 16:44       ` Bartosz Golaszewski
2017-02-13 18:35       ` Kevin Hilman
2017-02-07 16:41 ` [PATCH 09/10] media: vpif: use a configurable i2c_adapter_id for vpif display Bartosz Golaszewski
2017-02-07 18:16   ` Kevin Hilman [this message]
2017-02-07 16:41 ` [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm " Bartosz Golaszewski
2017-02-07 18:20   ` Kevin Hilman
2017-02-08 13:26     ` Bartosz Golaszewski
2017-02-10 19:40   ` Kevin Hilman
2017-02-13  9:22 ` [PATCH 00/10] ARM: davinci: add vpif display support Sekhar Nori
2017-02-16 17:48   ` Bartosz Golaszewski
2017-03-09 10:53 ` Hans Verkuil
2017-03-09 11:00   ` Bartosz Golaszewski
2017-03-09 12:05     ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2r339kgs3.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=abailon@baylibre.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nsekhar@ti.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=ptitiano@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox