From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932183AbcISQoO (ORCPT ); Mon, 19 Sep 2016 12:44:14 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33177 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbcISQoL (ORCPT ); Mon, 19 Sep 2016 12:44:11 -0400 From: Kevin Hilman To: Martin Blumenstingl Cc: Axel Lin , Kishon Vijay Abraham I , Jerome Brunet , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] phy: meson-usb2: Fix build dependency Organization: BayLibre References: <1473991635-27973-1-git-send-email-axel.lin@ingics.com> Date: Mon, 19 Sep 2016 09:44:08 -0700 In-Reply-To: (Martin Blumenstingl's message of "Sun, 18 Sep 2016 23:41:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Martin Blumenstingl writes: > Hi Axel, > > On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin wrote: >> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below >> build error: >> >> drivers/built-in.o: In function `phy_meson_usb2_probe': >> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy' >> Makefile:961: recipe for target 'vmlinux' failed >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Axel Lin >> --- >> drivers/phy/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index 6ad87ec..cc27c12 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -458,6 +458,8 @@ config PHY_MESON_USB2 >> tristate "Meson USB2 PHY driver" >> default ARCH_MESON >> depends on OF && (ARCH_MESON || COMPILE_TEST) >> + depends on USB_SUPPORT >> + select USB_COMMON >> select GENERIC_PHY >> help >> Enable this to support the Meson USB2 PHYs found in Meson8b >> -- >> 2.7.4 >> > thanks for this patch! > > How do we handle patches for drivers which will (unfortunately) not > land in the linux 4.8 - should I integrate that into v3 of the patch > (which I'll have to send anyways) or do we keep them separate? > Maybe Kishon and/or Kevin can share their opinion on this. It's up to Kishon if he wants a v3, or if he can fold in the fix himself. Kevin