From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759321AbcIHSRP (ORCPT ); Thu, 8 Sep 2016 14:17:15 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:36466 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758521AbcIHSRL (ORCPT ); Thu, 8 Sep 2016 14:17:11 -0400 From: Kevin Hilman To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Neil Armstrong , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree , Rob Herring Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Organization: BayLibre References: <1473321206-32284-1-git-send-email-narmstrong@baylibre.com> <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> Date: Thu, 08 Sep 2016 11:17:08 -0700 In-Reply-To: <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Thu, 8 Sep 2016 14:50:37 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u88IHLl2027430 Andreas Färber writes: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: >> Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >>> This patchset adds a specific compatible string in the Meson SPIFC driver for >>> the Amlogic Meson GXBB SoC. >> >> Any particular reason? We could just reuse the meson6 one since there >> appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) I'm not sure what the "right" way is (Rob?) but I think the usual way is to add new compatibles when needed. Kevin