From: Andi Kleen <andi@firstfloor.org>
To: mingo@kernel.org
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl, torvalds@linux-foundation.org,
pjt@google.com, cl@linux.com, riel@redhat.com,
bharata.rao@gmail.com, akpm@linux-foundation.org,
Lee.Schermerhorn@hp.com, aarcange@redhat.com, danms@us.ibm.com,
suresh.b.siddha@intel.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/numa] mm/mpol: Lazy migrate a process/vma
Date: Mon, 21 May 2012 16:14:15 -0700 [thread overview]
Message-ID: <m2r4ud86uw.fsf@firstfloor.org> (raw)
In-Reply-To: <tip-pdhg3wh71m4eu8xerantpvln@git.kernel.org> (tip-bot for Peter Zijlstra's message of "Fri, 18 May 2012 03:33:08 -0700")
tip-bot for Peter Zijlstra <a.p.zijlstra@chello.nl> writes:
> +
> + /*
> + * Obtain a more-or-less correct nodemask to find which pages we need
> + * to unmap so that MoF can put them right again.
> + *
> + * Not quite correct for INTERLEAVE, that would need us doing
> + * offset_il_node() from check_pte_entry().
> + *
> + * Also not quite correct for task policies since we don't have a task,
> + * approximate by having @node function as local / task-home-node.
Hmm, so this destroys existing numa policies for already running processes?
Andrea's original THP had a similar problem, and it caused serious
performance problems before it was fixed.
I also seem to miss the benchmark numbers justifying all that code.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
prev parent reply other threads:[~2012-05-21 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 10:33 [tip:sched/numa] mm/mpol: Lazy migrate a process/vma tip-bot for Peter Zijlstra
2012-05-21 23:14 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r4ud86uw.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bharata.rao@gmail.com \
--cc=cl@linux.com \
--cc=danms@us.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=riel@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox