Re: [PATCH][v3.1] blkio: Add io controller stats like

[Divyesh Shah <dpshah@google.com>]

On Thu, Apr 8, 2010 at 5:46 AM, Jens Axboe <jens.axboe@oracle.com> wrote:
> On Thu, Apr 08 2010, Gui Jianfeng wrote:
>> Divyesh Shah wrote:
>> > - io_service_time (the total time between request dispatch and completion for
>> >   all IOs in the cgroup)
>> > - io_wait_time (the total time spent waiting by all IOs in this cgroup in the IO
>> >   scheduler queues before getting serviced)
>> > - io_serviced (number of IOs serviced from this blkio_group)
>> > - io_service_bytes (Number of bytes served for this cgroup)
>> >
>> > These stats are accumulated per operation type helping us to distinguish between
>> > read and write, and sync and async IO. This patch does not increment any of
>> > these stats.
>> >
>> > Changelog from v3:
>> > o renamed blkiocg_reset_write to blkiocg_reset_stats
>> > o more clarification in the documentation on io_service_time and io_wait_time.
>> >
>> > Signed-off-by: Divyesh Shah<dpshah@google.com>
>>
>> Hi Divyesh,
>>
>> Jens has already applied previous patchset to for-2.6.35 branch, so v3 patchset
>> and this patch have conflicts with for-2.6.35 branch. I think it's better to make
>> new patch on top of for-2.6.35.
>
> Thanks, was just about to ask. Please make an updated patch against what
> I already have, so I don't have to revert/rebase to make this work.

Sure, I'll post an updated patch today.

>
> --
> Jens Axboe
>
>