From: Andreas Schwab <schwab@linux-m68k.org>
To: Al Viro <public-viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@plane.gmane.org>
Cc: public-linux-nfs-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org,
Chuck Lever
<public-chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@plane.gmane.org>,
public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org
Subject: Re: [PATCH] fix return values of rpcb_create_local()
Date: Sun, 05 Jun 2011 15:06:50 +0200 [thread overview]
Message-ID: <m2tyc4whp1.fsf@igel.home> (raw)
In-Reply-To: <20110605130207.GE11521@ZenIV.linux.org.uk> (Al Viro's message of "Sun, 5 Jun 2011 14:02:07 +0100")
Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> writes:
> diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
> index 9a80a92..5efaf5f 100644
> --- a/net/sunrpc/rpcb_clnt.c
> +++ b/net/sunrpc/rpcb_clnt.c
> @@ -193,7 +193,7 @@ static int rpcb_create_local_unix(void)
> if (IS_ERR(clnt)) {
> dprintk("RPC: failed to create AF_LOCAL rpcbind "
> "client (errno %ld).\n", PTR_ERR(clnt));
> - result = -PTR_ERR(clnt);
> + result = PTR_ERR(clnt);
> goto out;
> }
>
> @@ -242,7 +242,7 @@ static int rpcb_create_local_net(void)
> if (IS_ERR(clnt)) {
> dprintk("RPC: failed to create local rpcbind "
> "client (errno %ld).\n", PTR_ERR(clnt));
> - result = -PTR_ERR(clnt);
> + result = PTR_ERR(clnt);
Proabably the dprintk argument should be negated as well.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2011-06-05 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 13:02 [PATCH] fix return values of rpcb_create_local() Al Viro
2011-06-05 13:06 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tyc4whp1.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=public-chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@plane.gmane.org \
--cc=public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org \
--cc=public-linux-nfs-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org \
--cc=public-viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox