From: Andreas Schwab <schwab@linux-m68k.org>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: state machine defect in drivers/tty/vt/vt.c?
Date: Sun, 10 Jul 2011 20:12:30 +0200 [thread overview]
Message-ID: <m2vcvac8dt.fsf@igel.home> (raw)
In-Reply-To: <1310317919.3848.38.camel@Joe-Laptop> (Joe Perches's message of "Sun, 10 Jul 2011 10:11:59 -0700")
Joe Perches <joe@perches.com> writes:
> vc->vc_state is sequentially set to different values.
>
> Looks like there's either a return or a break
> missing at the end of case ESgetpars:
>
> Anyone know the right fix here?
The first assignment can be removed.
> case ESgetpars:
> if (c == ';' && vc->vc_npar < NPAR - 1) {
> vc->vc_npar++;
> return;
> } else if (c>='0' && c<='9') {
> vc->vc_par[vc->vc_npar] *= 10;
> vc->vc_par[vc->vc_npar] += c - '0';
> return;
> } else
> vc->vc_state = ESgotpars;
> case ESgotpars:
> vc->vc_state = ESnormal;
That handles cases like '\033[m' where '\033[' enters state ESgetpars,
but 'm' is handled by ESgotpars.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2011-07-10 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 17:11 state machine defect in drivers/tty/vt/vt.c? Joe Perches
2011-07-10 18:12 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcvac8dt.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox