From: Peter Osterlund <petero2@telia.com>
To: Patrick Mochel <mochel@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [bk patch] Make cardbus compile in -pre4
Date: 09 Feb 2002 12:44:51 +0100 [thread overview]
Message-ID: <m2vgd6hob0.fsf@ppro.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.33.0202081824070.25114-100000@segfault.osdlab.org>
In-Reply-To: <Pine.LNX.4.33.0202081824070.25114-100000@segfault.osdlab.org>
Patrick Mochel <mochel@osdl.org> writes:
> I broke cardbus compile in -pre4 on accident. Sorry about that...
It compiles in -pre5 but doesn't work unless you also apply the patch
below. Without this patch, bus_id will be empty which makes
device_register fail.
--- linux/drivers/pcmcia/cardbus.c.old Sat Feb 9 12:39:49 2002
+++ linux/drivers/pcmcia/cardbus.c Sat Feb 9 12:14:36 2002
@@ -279,13 +279,13 @@
pci_readw(dev, PCI_DEVICE_ID, &dev->device);
dev->hdr_type = hdr & 0x7f;
+ pci_setup_device(dev);
+
dev->dev.parent = bus->dev;
strcpy(dev->dev.name, dev->name);
strcpy(dev->dev.bus_id, dev->slot_name);
device_register(&dev->dev);
- pci_setup_device(dev);
-
/* FIXME: Do we need to enable the expansion ROM? */
for (r = 0; r < 7; r++) {
struct resource *res = dev->resource + r;
--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
next prev parent reply other threads:[~2002-02-09 11:45 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-09 2:25 [bk patch] Make cardbus compile in -pre4 Patrick Mochel
2002-02-09 3:39 ` Andreas Dilger
2002-02-09 4:02 ` Jeff Garzik
2002-02-09 7:29 ` Andreas Dilger
2002-02-09 7:41 ` Larry McVoy
2002-02-10 2:39 ` Jeff Garzik
2002-02-10 3:52 ` Linus Torvalds
2002-02-10 7:47 ` Andreas Dilger
2002-02-10 20:57 ` Linus Torvalds
2002-02-11 18:38 ` Andreas Dilger
2002-02-09 5:12 ` Larry McVoy
2002-02-09 5:32 ` Andrew Morton
2002-02-09 9:36 ` Rob Landley
2002-02-09 9:57 ` Momchil Velikov
2002-02-09 10:01 ` Alexander Viro
2002-02-09 18:09 ` Rob Landley
2002-02-09 15:08 ` Daniel Phillips
2002-02-10 4:07 ` Linus Torvalds
2002-02-09 10:14 ` David Lang
2002-02-09 15:54 ` Larry McVoy
2002-02-09 16:50 ` Tom Rini
2002-02-09 17:05 ` Larry McVoy
2002-02-09 21:01 ` David Lang
2002-02-09 21:41 ` Larry McVoy
2002-02-09 23:36 ` Andreas Dilger
2002-02-09 23:45 ` Tom Rini
2002-02-10 0:42 ` Andreas Dilger
2002-02-09 23:52 ` Larry McVoy
2002-02-10 4:13 ` Linus Torvalds
2002-02-10 18:02 ` Tom Rini
2002-02-10 5:25 ` William Stearns
2002-02-11 17:30 ` Padraig Brady
2002-02-13 11:59 ` Padraig Brady
2002-02-09 9:27 ` pull vs push (was Re: [bk patch] Make cardbus compile in -pre4) Rob Landley
2002-02-09 10:08 ` Andreas Dilger
2002-02-09 18:12 ` Stelian Pop
2002-02-09 20:59 ` Linus Torvalds
2002-02-09 20:12 ` Stelian Pop
2002-02-09 20:26 ` Larry McVoy
2002-02-09 20:51 ` Stelian Pop
2002-02-09 23:45 ` Jeff Garzik
2002-02-09 23:49 ` Larry McVoy
2002-02-09 20:57 ` Pau Aliagas
2002-02-09 21:07 ` David Lang
2002-02-09 21:13 ` Pau Aliagas
2002-02-09 21:45 ` Rob Landley
2002-02-10 0:19 ` Andreas Dilger
2002-02-10 0:36 ` Herbert Xu
2002-02-10 0:54 ` ssh primer (was Re: pull vs push (was Re: [bk patch] Make cardbus compile in -pre4)) Jeff Garzik
2002-02-10 0:59 ` Herbert Xu
2002-02-10 1:24 ` Jeff Garzik
2002-02-10 8:13 ` Herbert Xu
2002-02-13 17:13 ` Aaron Lehmann
2002-02-14 0:22 ` Rob Landley
2002-02-14 6:57 ` Aaron Lehmann
2002-02-14 11:00 ` Harald Arnesen
2002-02-10 0:59 ` Ben Pfaff
2002-02-10 1:14 ` David Lang
2002-02-10 1:22 ` ssh primer (was Re: pull vs push (was Re: [bk patch] Make cardbuscompile " Jeff Garzik
2002-02-10 2:46 ` pull vs push (was Re: [bk patch] Make cardbus compile in -pre4) Alan Cox
2002-02-11 11:51 ` Pavel Machek
2002-02-11 18:42 ` John Alvord
2002-02-09 11:44 ` Peter Osterlund [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-02-10 20:12 [bk patch] Make cardbus compile in -pre4 Chris Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vgd6hob0.fsf@ppro.localdomain \
--to=petero2@telia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox