From: Juan Quintela <quintela@mandrakesoft.com>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>,
torvalds@transmeta.com, viro@math.psu.edu,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
ext2-devel@lists.sourceforge.net
Subject: Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)
Date: 07 Jan 2002 21:54:03 +0100 [thread overview]
Message-ID: <m2vgedq3v8.fsf@neno.dmz> (raw)
In-Reply-To: <20020107132121.241311F6A@gtf.org> <E16NbYF-0001Qq-00@starship.berlin>
In-Reply-To: <E16NbYF-0001Qq-00@starship.berlin>
>>>>> "daniel" == Daniel Phillips <phillips@bonn-fries.net> writes:
Hi
daniel> Minor nit:
daniel> if (!inode->u.ext2_ip)
daniel> BUG();
daniel> You don't have to do this, if the pointer is null you will get a perfectly
daniel> fine oops.
Without nice line information :(
Later, Juan.
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next prev parent reply other threads:[~2002-01-07 22:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-07 13:21 PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7) Jeff Garzik
2002-01-07 14:13 ` Anton Altaparmakov
2002-01-07 15:33 ` Daniel Phillips
2002-01-07 21:27 ` Jeff Garzik
2002-01-08 6:32 ` Daniel Phillips
2002-01-08 6:31 ` Jeff Garzik
2002-01-08 6:38 ` Daniel Phillips
2002-01-07 16:01 ` Anton Altaparmakov
2002-01-07 16:23 ` Daniel Phillips
2002-01-07 17:25 ` Mark Zealey
2002-01-07 15:19 ` Daniel Phillips
2002-01-07 20:54 ` Juan Quintela [this message]
2002-01-08 4:10 ` Daniel Phillips
2002-01-07 21:25 ` Jeff Garzik
2002-01-08 3:06 ` Daniel Phillips
2002-01-07 23:48 ` Jeff Garzik
2002-01-08 0:15 ` Andreas Dilger
2002-01-08 0:17 ` Jeff Garzik
2002-01-08 3:28 ` Daniel Phillips
2002-01-07 16:10 ` Daniel Phillips
2002-01-07 19:38 ` Alexander Viro
2002-01-07 21:37 ` Jeff Garzik
2002-01-07 23:28 ` [PATCH 7/7 v2] " Jeff Garzik
2002-01-07 23:49 ` [Ext2-devel] " Andreas Dilger
2002-01-07 23:52 ` Jeff Garzik
2002-01-07 21:32 ` Jeff Garzik
2002-01-07 21:49 ` Arnaldo Carvalho de Melo
2002-01-07 21:58 ` Jeff Garzik
2002-01-07 23:46 ` Jeff Garzik
2002-01-08 0:17 ` [Ext2-devel] " Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vgedq3v8.fsf@neno.dmz \
--to=quintela@mandrakesoft.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox