public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charalampos Mitrodimas <charmitro@posteo.net>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Cc: a.hindborg@kernel.org,  alex.gaynor@gmail.com,
	 aliceryhl@google.com, apw@canonical.com,  arnd@arndb.de,
	 aswinunni01@gmail.com, axboe@kernel.dk,  benno.lossin@proton.me,
	 bhelgaas@google.com, bjorn3_gh@protonmail.com,
	 boqun.feng@gmail.com,  dakr@kernel.org, dwaipayanray1@gmail.com,
	 ethan.twardy@gmail.com, fujita.tomonori@gmail.com,
	 gary@garyguo.net, gregkh@linuxfoundation.org,  joe@perches.com,
	 lukas.bulwahn@gmail.com, ojeda@kernel.org,  pbonzini@redhat.com,
	 tmgross@umich.edu, walmeida@microsoft.com,
	 rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH V6 1/2] rust: module: change author to an array
Date: Mon, 24 Feb 2025 22:07:00 +0000	[thread overview]
Message-ID: <m2wmdfov3v.fsf@posteo.net> (raw)
In-Reply-To: <20250223174205.48404-2-trintaeoitogc@gmail.com>

Guilherme Giacomo Simoes <trintaeoitogc@gmail.com> writes:

> In the module! macro, the author field is currently of type String.
> Since modules can have multiple authors, this limitation prevents
> specifying more than one.
> Change the author field to Option<Vec<String>> to allow creating modules
> with multiple authors. Additionally, rename the field from author to
> authors to make it explicit that it can refer to multiple authors.  In
> modules that use the author field, update its value to an array of
> strings, and also rename it from author to authors.
>
> Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/244
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
> ---
>  drivers/block/rnull.rs               |  2 +-
>  drivers/net/phy/ax88796b_rust.rs     |  2 +-
>  drivers/net/phy/qt2025.rs            |  2 +-
>  rust/kernel/net/phy.rs               |  4 ++--
>  rust/kernel/pci.rs                   |  2 +-
>  rust/kernel/platform.rs              |  2 +-
>  rust/macros/lib.rs                   |  6 +++---
>  rust/macros/module.rs                | 12 +++++++-----
>  samples/rust/rust_driver_faux.rs     |  2 +-
>  samples/rust/rust_driver_pci.rs      |  2 +-
>  samples/rust/rust_driver_platform.rs |  2 +-
>  samples/rust/rust_minimal.rs         |  2 +-
>  samples/rust/rust_misc_device.rs     |  2 +-
>  samples/rust/rust_print_main.rs      |  2 +-
>  14 files changed, 23 insertions(+), 21 deletions(-)

Rust side looks good to me. Thanks!

Reviewed-by: Charalampos Mitrodimas <charmitro@posteo.net>

  reply	other threads:[~2025-02-24 22:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <GQqgXevDlPrbDVqybjdBe8eWBr-bsr56Nmbydqom2kJLDE2mrH7hfWC0ORBSY3Qz7yaBd3mIoy9TcKjNz96hzA==@protonmail.internalid>
2025-02-23 17:42 ` [PATCH V6 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-02-23 17:42   ` [PATCH V6 1/2] rust: module: change author to an array Guilherme Giacomo Simoes
2025-02-24 22:07     ` Charalampos Mitrodimas [this message]
2025-03-04 12:09     ` Andreas Hindborg
2025-03-04 12:52     ` Alice Ryhl
2025-02-23 17:42   ` [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules Guilherme Giacomo Simoes
2025-03-04 12:16     ` Andreas Hindborg
2025-03-04 20:50       ` Guilherme Giacomo Simoes
2025-03-04 21:00         ` Miguel Ojeda
2025-03-04 21:01           ` Miguel Ojeda
2025-03-05  7:53             ` Andreas Hindborg
2025-03-05 11:04               ` Miguel Ojeda
2025-03-05 11:08                 ` Andreas Hindborg
2025-03-06 16:18                 ` Guilherme Giacomo Simoes
2025-03-06 16:32                 ` Guilherme Giacomo Simoes
2025-03-06 16:33                   ` Miguel Ojeda
2025-03-06  1:59           ` Guilherme Giacomo Simoes
2025-03-06 11:39             ` Miguel Ojeda
2025-03-06 16:08               ` Guilherme Giacomo Simoes
2025-03-06 16:36                 ` Miguel Ojeda
2025-03-06 17:18                   ` Guilherme Giacomo Simoes
2025-03-06 17:19                     ` Miguel Ojeda
2025-03-04 11:59   ` [PATCH V6 0/2] author field in module! macro should be a array Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wmdfov3v.fsf@posteo.net \
    --to=charmitro@posteo.net \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=aswinunni01@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=ethan.twardy@gmail.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=trintaeoitogc@gmail.com \
    --cc=walmeida@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox