From: Andi Kleen <andi@firstfloor.org>
To: Prasad Koya <prasad.koya@gmail.com>
Cc: dzickus@redhat.com, aarcange@redhat.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: vmalloc_sync_all(), 64bit kernel, patches 9c48f1c629ecfa114850c03f875c6691003214de, a79e53d85683c6dd9f99c90511028adc2043031f
Date: Thu, 29 Nov 2012 11:11:28 -0800 [thread overview]
Message-ID: <m2wqx4fcm7.fsf@firstfloor.org> (raw)
In-Reply-To: <CAGXD9OfAMUmrdFBap3aOYXOhXE6=i8qL7=+SsJYnrdEr3kyMKw@mail.gmail.com> (Prasad Koya's message of "Mon, 26 Nov 2012 15:06:53 -0800")
Prasad Koya <prasad.koya@gmail.com> writes:
> Hi
>
> Before going into crashkernel, nmi_shootdown_cpus() calls
> register_die_notifier(), which calls vmalloc_sync_all(). I'm seeing
> lockup in sync_global_pgds() (init_64.c). From 3.2 and up,
> register_die_notifier() is replaced with register_nmi_handler() (patch
> 9c48f1c629ecfa114850c03f875c6691003214de), which doesn't call
> vmalloc_sync_all(). Is it ok to skip vmalloc_sync_all() in this path?
Yes it's ok for this case. vmalloc_sync_all is only needed when the
notifier is in freshly loaded module code.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
prev parent reply other threads:[~2012-11-29 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 23:06 vmalloc_sync_all(), 64bit kernel, patches 9c48f1c629ecfa114850c03f875c6691003214de, a79e53d85683c6dd9f99c90511028adc2043031f Prasad Koya
2012-11-27 14:55 ` Don Zickus
2012-11-27 23:20 ` Prasad Koya
2012-11-28 15:22 ` Don Zickus
2012-11-29 19:11 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wqx4fcm7.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=aarcange@redhat.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasad.koya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox