From: Andreas Schwab <schwab@linux-m68k.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
"Artem S. Tashkinov" <t.artem@mailcity.com>,
Dave Jones <davej@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t
Date: Thu, 22 Dec 2011 11:18:36 +0100 [thread overview]
Message-ID: <m2wr9o52pv.fsf@igel.home> (raw)
In-Reply-To: <20111221161944.ec1c49f9.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 21 Dec 2011 16:19:44 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 22 Dec 2011 01:14:39 +0100
> Andreas Schwab <schwab@linux-m68k.org> wrote:
>
>> > a) what effect does this problem have upon users of the kernel?
>>
>> get_idle_time returns the value in the wrong unit.
>
> So the "idle" fields in /proc/stat are wrong.
>
> We're getting there! Now, in what way are they wrong?
They use the wrong unit, off by the factor between jiffies and cputime.
> How could a kernel maintainer recognise that this patch is needed?
By running the kernel on one of the architectures that are affected (did
I already say that on most architectures jiffies and cputime are
equivalent?).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-12-22 10:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m28vmi7ip3.fsf@igel.home>
2011-12-12 8:16 ` [PATCH] procfs: do not confuse jiffies with cputime64_t Michal Hocko
2011-12-12 9:22 ` Arnd Bergmann
2011-12-12 10:17 ` Andreas Schwab
2011-12-12 11:51 ` [PATCH v2] " Andreas Schwab
2011-12-12 12:43 ` Michal Hocko
2011-12-12 13:07 ` [PATCH v3] " Andreas Schwab
2011-12-12 13:12 ` Michal Hocko
2011-12-21 10:03 ` [resend PATCH for 3.2] " Michal Hocko
2011-12-21 19:43 ` Andrew Morton
2011-12-21 19:59 ` Andrew Morton
2011-12-21 23:50 ` Andreas Schwab
2011-12-21 23:56 ` Andrew Morton
2011-12-22 0:14 ` Andreas Schwab
2011-12-22 0:19 ` Andrew Morton
2011-12-22 10:18 ` Andreas Schwab [this message]
2011-12-21 23:55 ` Andreas Schwab
2011-12-21 23:59 ` Andrew Morton
2011-12-22 0:20 ` Andreas Schwab
2011-12-22 9:55 ` Martin Schwidefsky
2011-12-22 10:19 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wr9o52pv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=schwidefsky@de.ibm.com \
--cc=t.artem@mailcity.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).